Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9506 closed defect (fixed)

DropDownButton: ESC key doesn't close (safari 4)

Reported by: bill Owned by: Becky Gibson
Priority: high Milestone: 1.4
Component: Accessibility Version: 1.3.0
Keywords: Cc:
Blocked By: Blocking:

Description

See test_Button.html, and open the drop down for the DropDownButton or ComboButton. The ESC key doesn't close it (on safari 4).

Working correctly on FF3.5/mac.

Change History (8)

comment:1 Changed 10 years ago by Becky Gibson

Note that the escape handler in _base/popup.js never gets invoked in Safari.

comment:2 Changed 10 years ago by Becky Gibson

This is due to the special keypress handling for isWebKit in dojo/_base/event.js. I'm not sure I'm the best one to make changes in event.js :-) I suspect that we no longer need this or need a different approach in Safari 4.

comment:3 Changed 10 years ago by bill

Thanks for tracking that down. OK, I filed #9528 to track the problem in dojo/_base/event.js.

comment:4 Changed 10 years ago by bill

(In [18800]) Enable robot tests on Chrome now that it's working. Thanks Mark! (refs #9526).

Also disabling keyboard tests on safari 4 / chrome 2 until the keyboard bugs are fixed (refs #8987, #9506).

comment:5 Changed 10 years ago by Becky Gibson

Milestone: 1.41.3.2

comment:6 Changed 10 years ago by Adam Peller

Milestone: 1.3.21.4

because Safari never really had keyboard support, I'm not sure it makes sense to hold up the 1.3.2 build for this, especially if there is no patch pending.

comment:7 Changed 10 years ago by bill

Resolution: fixed
Status: newclosed

This is working on latest Safari (4.0.3) and Chrome (v3) now, although it doesn't work against Dojo 1.3, so we must have done something to fix it, maybe the _HasDropDown work.

comment:8 Changed 10 years ago by bill

(In [20113]) Keyboard is more-or-less working for safari and chrome. Enabling the keyboard tests for all browsers. Refs #9506, #8987.

Note: See TracTickets for help on using tickets.