Opened 10 years ago

Closed 7 years ago

#9485 closed defect (patchwelcome)

tabing into grid data that contains a checkbox sets focus to the checkbox rather than 1st cell

Reported by: Becky Gibson Owned by: Bryan Forbes
Priority: high Milestone: tbd
Component: DojoX Grid Version: 1.2.0
Keywords: a11y Cc: Joseph Scheuhammer
Blocked By: Blocking:

Description

This started happening in 1.2 when the grid was modified to make the column headers keyboard navigable. It is visually apparent in IE 7 or 8.

Load dojox/grid/tests/test_edit_canEdit.html. Tab through the buttons at the top and tab into the grid data. Note that when you first tab into the data, the focus border is drawn around the first cell, but the checkbox in the first row has a focus outline drawn around it. This checkbox is actually the item with focus - you can confirm that by pressing space and the checkbox will be checked. Arrow key navigation works correctly because the grid code believes that the first cell has focus.

Change History (4)

comment:1 Changed 10 years ago by Becky Gibson

Summary: first tab into grid data that contains a checkbox sets focus to the checkbox rather than 1st celltabing into grid data that contains a checkbox sets focus to the checkbox rather than 1st cell

debugging notes:

After completing focusManager.nextKey() to process the tab key press into the grid, I see focus get set to the first cell and then it moves to the checkbox. This seems to be the result of an onfocus event handler via registerWin() in dijit/_base/focus.js and subsequent calls to dijit._onFocusNode(effectiveNode
evt.target); The checkbox is an AlwaysEdit? type of cell: dojox.grid.cells.Bool

comment:2 Changed 10 years ago by Becky Gibson

I suspect this has to do with the addtion of AlwaysEdit? for cell types and the creation of dojox.grid.cells.Bool.

comment:3 Changed 7 years ago by bill

DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:4 Changed 7 years ago by bill

Resolution: patchwelcome
Status: newclosed
Note: See TracTickets for help on using tickets.