#9471 closed defect (fixed)
Calendar: in high contrast mode, dijit.form.DateTextBox has issue that underline is displayed on top of the current date
Reported by: | mabingd | Owned by: | |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | Dijit - Form | Version: | 1.3.0 |
Keywords: | a11y | Cc: | Becky Gibson |
Blocked By: | Blocking: |
Description (last modified by )
Attachments (2)
Change History (11)
Changed 12 years ago by
Attachment: | calendar in high contrast mode.JPG added |
---|
comment:1 Changed 12 years ago by
Cc: | Becky Gibson added |
---|---|
Component: | General → Dijit |
Keywords: | a11y added |
Owner: | anonymous deleted |
comment:2 Changed 12 years ago by
Description: | modified (diff) |
---|---|
Milestone: | tbd → 1.4 |
Summary: | In high contrast mode, dijit.form.DateTextBox has issue that underline is displayed on top of the current date → Calendar: in high contrast mode, dijit.form.DateTextBox has issue that underline is displayed on top of the current date |
comment:3 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:4 Changed 12 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I specifically used overline to fix #5643 because underline is already used for the current date. There needs to be a way to distinguish the current date from the selected date in high contrast mode. I am open to other methods to indicate the current date and selected date but I'm not sure what to use - a border would be very hard to implement without making the characters "jump" with the addition of the border. Any other ideas?
comment:5 Changed 12 years ago by
Oh I see... I'm not sure we need to worry about jumping since the calendar is typically a drop down that disappears as soon as you select a date, but anyway I'm attaching a patch that creates a border and then uses padding to avoid screen jitter. How's it look to you?
Changed 12 years ago by
Attachment: | a11yCalendar.patch added |
---|
use border to indicate selected date, no screen jumping on selecting a date
comment:6 Changed 12 years ago by
Yes, this looks fine. The only concern I have is that someone is working on adding keyboard navigation to the calendar popup. Will the padding still take care of screen jitter if the selection is being changed with the popup open?
comment:7 Changed 12 years ago by
Yes, check out test_Calendar.html... there's no jitter there so I think it's fine.
comment:8 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:9 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
I'm not sure why you call this an issue; the overline is there intentionally to indicte the selected date. Added in [12405]. However, I think an underline would be more conventional (and seems to work in IE6, IE7, and FF3), so I'll change the code to that.
Becky, let us know if using an underline is bad for some reason. Note that disabled dates are crossed out (bar centered vertically).