Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9469 closed defect (fixed)

[dojox.image] LightboxNano should work programatically

Reported by: dante Owned by: cb1kenobi
Priority: high Milestone: 1.4
Component: Dojox Version: 1.3.0
Keywords: Cc:
Blocked By: Blocking:

Description

as discussed in #dojo, it would be great if a LightboxNano? could act as a generic "popup" for images. Currently (1.3) it requires existing markup during construction. The use case would be using an existing delegated click/UI mechanism, and showing a LightboxNano? from some passed image url originating from some passed node. As one lightbox is only ever showing at once, a single lightbox instance could be used for all existing links on a page (current api) as well as handle the singleton creation.

Attachments (1)

prog-nano.patch​ (16.5 KB) - added by dante 10 years ago.
same as previous patch but with documentation for the show() function

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by dante

Attachment: prog-nano.patch​ added

same as previous patch but with documentation for the show() function

comment:1 Changed 10 years ago by dante

Milestone: tbd → 1.4

Attached is a patch which adds this ability, maintains back compat, and only adds a handful of bytes. One public API exposed show, with inline docs. Does exactly as I need, would love to see this land in 1.4. please review.

comment:2 Changed 10 years ago by dante

Priority: normal → high

have you had a chance to review this

comment:3 Changed 10 years ago by cb1kenobi

Status: new → assigned

comment:4 Changed 10 years ago by cb1kenobi

Resolution: → fixed
Status: assigned → closed

comment:5 Changed 10 years ago by cb1kenobi

(In [20384]) Found small bug when no origin is specified, the dummy centered node is not destroyed causing several divs to get added to the page. refs #9469 !strict

Note: See TracTickets for help on using tickets.