Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9446 closed defect (fixed)

Incorrect margin-top for dijit textboxes in IE8 quirks mode

Reported by: Kris Zyp Owned by: nonken
Priority: high Milestone: 1.3.2
Component: themes Version: 1.3.0
Keywords: Cc: Douglas Hays, bill, Adam Peller
Blocked By: Blocking:

Description

The characters entered into a dijit form textbox show up with the characters too high (cut off at the top). The rule on line 60: .dj_iequirks .dijitInputField INPUT seems to be causing the problem. Seems like this should be removed or the attached patch should be applied

Attachments (1)

fix_ie8_in_quirks_mode.patch​ (497 bytes) - added by Kris Zyp 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by Kris Zyp

Attachment: fix_ie8_in_quirks_mode.patch​ added

comment:1 Changed 10 years ago by Kris Zyp

Cc: Douglas Hays bill added

comment:2 Changed 10 years ago by Douglas Hays

I removed that rule entirely and things look better when running dijit/tests/form/test_valdate.html in IE6 and 7 with no DOCTYPE.

comment:3 Changed 10 years ago by Douglas Hays

Resolution: → fixed
Status: new → closed

(In [18457]) Fixes #9446. Removed negative top margin for TextBox? subclasses and IE quirks. Tested ValidationTextBox?, Spinner, ComboBox?, and FilePickerTextBOx on IE6, 7, 8, all with no DOCTYPE.

comment:4 Changed 10 years ago by Douglas Hays

Cc: Adam Peller added

I would like to fix this in 1.3.2 since it's pervasive and a simple fix.

comment:5 Changed 10 years ago by Adam Peller

Milestone: tbd → 1.4

comment:6 Changed 10 years ago by Douglas Hays

Milestone: 1.4 → 1.3.2

comment:7 Changed 10 years ago by Douglas Hays

(In [18484]) Fixes #9446 in 1.3.2. Removed iequirks rule for TextBox? subclasses since it was making the vertical alignment too high.

Note: See TracTickets for help on using tickets.