Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#9437 closed defect (fixed)

ComboBox: when inputing Chinese words in the filter does not work

Reported by: qxo Owned by: bill
Priority: high Milestone: 1.4
Component: Dijit - Form Version: 1.3.1
Keywords: combobox Cc: Douglas Hays
Blocked By: Blocking:

Description (last modified by bill)

See attached test case. After typing in naka/chuu (中)the drop down list still shows all the entries (including ones that don't match like "Apple").

Attachments (1)

comboboxDemo.html (5.6 KB) - added by qxo 10 years ago.
Demo And Fixed for the problem

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by qxo

Attachment: comboboxDemo.html added

Demo And Fixed for the problem

comment:1 Changed 10 years ago by qxo

input chinese word in dijit.form.ComboBox? widget,the filter not work!

comment:2 Changed 10 years ago by Eugene Lazutkin

Summary: input chese word in dijit.form.ComboBox widget,the filter not work!When inputing Chinese words in dijit.form.ComboBox widget, the filter does not work!

comment:3 Changed 10 years ago by Adam Peller

Cc: Douglas Hays added
Component: GeneralDijit
Owner: anonymous deleted

comment:4 Changed 10 years ago by Adam Peller

Have you submitted a CLA? We cannot look at a patch without a CLA.

comment:5 Changed 10 years ago by bill

Description: modified (diff)
Milestone: tbd1.4
Summary: When inputing Chinese words in dijit.form.ComboBox widget, the filter does not work!ComboBox: when inputing Chinese words in the filter does not work

Actually this is just a trivial (one line) change, just not expressed in a patch file. IME's generate keycode=229 (or undefined on FF). I'll check in the change.

comment:6 Changed 10 years ago by bill

Owner: set to bill
Status: newassigned

comment:7 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [18282]) Fix problem (regression?) where search list wasn't being filtered by IME input.

On IE and safari, IME's (for inputting kanji etc.) produce keycode = 229 for keystrokes while in the IME input mode, and then no special indication when the input is finished and the IME has inserted some characters into the <input> box.

Firefox, OTOH, has a compositionend event to indicate when the IME has inserted some characters into the input, and we handle that by producing a faux call to _onKeyPress() with no keycode defined at all.

Fixes #9437 !strict.

comment:8 Changed 10 years ago by bill

(In [18284]) Better fix for correctly detecting IME input on FF. Refs #9437 !strict.

comment:9 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.