Changes between Initial Version and Version 4 of Ticket #9429


Ignore:
Timestamp:
Jun 19, 2009, 1:21:24 AM (11 years ago)
Author:
bill
Comment:

This enhancement broke the Tree DnD tests on both FF and IE (on my PC). I think browsers can't keep up with 1000 events / sec. 10 events / sec is probably a reasonable number.

Given that other people likely have tests that call mouseMove() I think we should fix the test harness so the old tests work, rather than changing known tests.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9429

    • Property Owner changed from alex to liucougar
    • Property Status changed from new to reopened
    • Property Cc haysmark added
  • Ticket #9429 – Description

    initial v4  
    66
    77Looking at DOHRobot.java, in MouseMoveThread::run(), there are following lines:
    8 
     8{{{
    99robot.setAutoDelay(Math.max(duration/100,1));
    1010robot.mouseMove(x1, y1);
    1111int d = 100;
    12 
     12}}}
    1313d is basically how many mouse move events it should generate. I think
    1414it would be better if that is not hardcoded here. This is my proposed
    1515patch:
    16 
     16{{{
    1717robot.setAutoDelay(1);
    1818robot.mouseMove(x1, y1);
    1919int d = duration;
    20 
     20}}}
    2121set auto delay to 1 (this is different from the original code if
    2222duration !=100, but I think this won't affect much). duration will be