Formating Menu in Editor disabled in Safari

[sfox]

Safari 3.2.1 (OS X) In test_Editor.html in the dijit tests the Format menu (available in the 4th editor widget on that page) displays the disabled symbol when clicked on. So headings (and other formats) can't be applied.

[bill]

Hmm, you are right. It's working on FF/mac but not safari. Tested on ​test_Editor.html.

[sfox]

Just to clarify this bug seems to date back to the move from 1.1 to 1.2 --just looking at test_Editor.html behavior across past versions.

[bill]

Still broken in Safari 4. It's enabled but selecting the element doesn't have any effect.

[bill]

Might be worth fixing for 1.4 if possible (probably happens on chrome and safari windows too?)

[Jared Jurkiewicz]

I understand why this fails on WebKit/Safari? The underlying browser returns "" for the blocks when it does a queryCommandValue. I can work around this by using the range API to just walk up the ansestors from current selection.

There's also a MAJOR async issue with this plugin and IE. (FilteringSelect? is async on onChange, but the plugin assumes sync), so all hell breaks loose. Fixing that too.

[bill]

Thanks for working on that. If the async issues proves to be difficult, we could use the dijit.form.Select widget instead. Although IIRC Doug changed all the form widgets to fire onChange asynchronously, so I guess that wouldn't help.

[Jared Jurkiewicz]

No, I have it working, I think. I just want to put together enough tests for it to feel comfortable I got it working correctly/consistently across browser.

[Jared Jurkiewicz]

(In [20422]) Fixing Many FontChoice? bugs, from WebKit? failing to ID block formats, to issues with async setting and update. Tested on: IE6, 7, and 8, FireFox? 3.0, 3.5, Safari 4, and Google Chrome 3. fixes #9377

[bill]

(In [20444]) #8987 and #9506 are fixed, so the a11y tests can run on webkit now too. Actually they were running already from dijit/tests/module.js. Refs #9377.

[bill]

(In [21013]) Lots of test file cleanup, plus fixes related to using dijit.editor._selection given there are two copies of dojo simultaneously loaded (one in Editor_fontChoice.html and one in test_FontChoice.html), but just one copy of dijit (in test_FontChoice.html). Refs #9377, #9915.

[bill]

(In [21014]) Eliminate lots of duplicated code by reusing the same code block. Also added TODO's: the current tests don't test mouse or keyboard interaction at all. Refs #9377.