Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#9363 closed defect (fixed)

[patch] [cla] dojox.embed.QuickTime is slow to load

Reported by: cb1kenobi Owned by: Tom Trenka
Priority: high Milestone: 1.3.2
Component: Dojox Version: 1.3.1
Keywords: Cc:
Blocked By: Blocking:


When using dojox.embed.QuickTime? in a build, it is initialized on each page load. During initialization, it downloads a QuickTime? mov file for the purpose of testing the QuickTime? plugin version.

Turns out this is not necessary. Simply adding the <embed> tag with an empty "src" will allow access to the QuickTime? version. An empty "src" doesn't throw any JavaScript? errors or 404s, and appears to work just fine in FF3(mac/win), Opera9(mac/win), IE7, Safari 3(mac/win), Chrome v1 (win), and Stainless 0.6 (mac).

Attachments (2)

dojo 1.3 dojox.embed.QuickTime.patch (1.3 KB) - added by cb1kenobi 13 years ago.
dojox.embed.Quicktime v2.patch (9.8 KB) - added by cb1kenobi 13 years ago.

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by cb1kenobi

Changed 13 years ago by cb1kenobi

comment:1 Changed 13 years ago by cb1kenobi

The v2 patch cleaned up dojox.embed.Quicktime by consolidating variable declarations, shifting some code around, removing some of the old hacky stuff and add new hacky stuff.

Works now in IE6, IE7, IE8, Safari 3.2 (win), Safari 4 (mac), Chrome 2 (win), Opera 9.64 (win/mac), Opera 10b1 (win), FF2 (win), FF3 (linux, mac, win), Stainless 0.6 (mac).

It does not support Opera 8.54 (win) and I assume all versions of Opera prior to v9 do not work either.

comment:2 Changed 13 years ago by cb1kenobi

Resolution: fixed
Status: newclosed

(In [18480]) Fixed performance issues with dojox.embed.Quicktime. Removed the need to download a test file to determine the installed QuickTime? version. I also updated the code to be a bit tighter and use some of the new Dojo 1.3 goodies. I cleaned up the test file so it is more verbose about whether QuickTime? is available and supported.

Fixes #9363 !strict

comment:3 Changed 13 years ago by cb1kenobi


comment:4 Changed 13 years ago by cb1kenobi

(In [18768]) Applying changes that fix speed issues with dojox.embed.Quicktime due to a test movie being loaded on page load. Updated the code to use new Dojo 1.3 functionality. Made version testing embed tag offscreen so prevent it from being visible.

Refs #9363, !strict

Note: See TracTickets for help on using tickets.