#9356 closed enhancement (fixed)
Move dojox.form._HasDropDown to dijit
Reported by: | Nathan Toone | Owned by: | Nathan Toone |
---|---|---|---|
Priority: | low | Milestone: | 1.4 |
Component: | Dijit | Version: | 1.3.0 |
Keywords: | Cc: | bill | |
Blocked By: | Blocking: |
Description (last modified by )
The following things need to happen:
1 - Rename and flag as protected the following members:
dropDownNode -> _buttonNode
aroundNode -> _aroundNode
popupStateNode -> _popupStateNode
2 - Remove _onMenuMouseup from _HasDropDown
3 - Move the dijit.Menu-specific handling code from dojox.form.DropDownSelect? into _HasDropDown
4 - Move _HasDropDown to dijit._HasDropDown, and create a stub (deprecated) in dojox.form (in case anyone is using it)
5 - Upgrade the following dijit components to use _HasDropDown instead of their current code:
dijit.form.DropDownButton
dijit.form.ComboButton (extends from DropDownButton)
dijit.form.ComboBox
dijit.form.FilteringSelect (extends from ComboBox)
dijit.form._DateTimeTextBox
dijit.form.DateTextBox (extends from _DateTimeTextBox)
dijit.form.TimeTextBox (extends from _DateTimeTextBox)
6 - Cross fingers and wait for breakage reports to come in :)
Attachments (1)
Change History (20)
comment:1 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 13 years ago by
Changed 13 years ago by
Attachment: | DDSMigration.patch added |
---|
Patch which does the first 4 of these tasks (and also move dojox.form.DropDownSelect? to dijit.form.DropDownSelect?)
comment:3 Changed 13 years ago by
(In [19071]) Refs #9356 - initial 4 steps towards completing the migration of DropDownSelect?/_HasDropDown to dijit !strict
comment:4 Changed 13 years ago by
(In [19305]) Refs #9356 - do step 5 for DropDownButton? and ComboButton?
comment:5 Changed 13 years ago by
(In [19511]) refs #9356: fixed broken ComboButton? popupStateNode is renamed to _popupStateNode in ComboButton? in r19305
comment:7 Changed 13 years ago by
(In [19523]) Correctly account for page scroll when testing if the drop down menu has appeared over the drop down button, and the user has moused-up w/out moving off of the button. (BTW this can be tested on test_Button.html by making the browser window very short and then scrolling down to the first row of buttons)
Also switching from dojo.coords() to dojo.position().
comment:9 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Closing this as fixed - a separate bug will be opened for the migration of combobox, filtering select, and date/time text boxes. I don't want to destabilize those so close to 1.4...
comment:11 Changed 13 years ago by
comment:12 Changed 13 years ago by
comment:14 Changed 13 years ago by
comment:15 Changed 13 years ago by
comment:16 Changed 13 years ago by
comment:17 Changed 12 years ago by
(In [21203]) Don't orphan the drop down widget from the DOM tree; it causes TooltipDialog to prematurely load it's href (before the widget is visible), and also possibly other obscure problems, like if the app has dojo.query() code that runs on page load, and expects to find nodes in the drop down widget.
Fixes #10652, refs #9356 (the code which prevents the orphaning was removed in [19305] but I'm not sure why), !strict.
(In [17647]) Comment format/content update as per explanations from toonetown. Plus a few TODO/TODOC's.
Refs #9356 !strict