Opened 13 years ago
Closed 13 years ago
#9353 closed defect (fixed)
[cla][patch] Better Element test for getComputedStyle
Reported by: | Mark Wubben | Owned by: | James Burke |
---|---|---|---|
Priority: | high | Milestone: | 1.3.2 |
Component: | General | Version: | 1.3.0 |
Keywords: | Cc: | sjmiles, Douglas Hays, bill, Adam Peller | |
Blocked By: | Blocking: |
Description
gcs()
in dojo._base.html
tests if node instanceof HTMLElement
, due to #6657 and #7467. I'm running into a situation where the Dojo code is loaded inside a Greasemonkey script context, and acting on the DOM tree of a different web page. Here the instanceof HTMLElement
fails.
A better test would be to check if the nodeType
of node
equals 1
, as is done in the IE branch of the code. See attached patch.
Attachments (1)
Change History (7)
Changed 13 years ago by
Attachment: | html.js.patch added |
---|
comment:1 Changed 13 years ago by
Milestone: | tbd → 1.4 |
---|---|
Owner: | changed from anonymous to James Burke |
comment:2 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 13 years ago by
Cc: | Douglas Hays bill added |
---|
If we want to support Safari 4 in 1.3.x, this needs to be backported since this change fixes several problems with dijit/tests/_base/test_scroll.html using Safari 4.
comment:4 Changed 13 years ago by
Cc: | Adam Peller added |
---|---|
Milestone: | 1.4 → 1.3.2 |
Resolution: | fixed |
Status: | closed → reopened |
comment:6 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Note: See
TracTickets for help on using
tickets.
(In [17631]) Fixes #9353: Fix from Mark Wubben (CLA on file) for a better node test that works in other environments like greasemonkey. \!strict for existing code