Opened 11 years ago

Closed 10 years ago

#9337 closed defect (fixed)

[patch] [ccla] IE7 failed dojo._base.NodeList.concat

Reported by: Michkovsky Owned by: Eugene Lazutkin
Priority: high Milestone: 1.4
Component: Core Version: 1.3.0
Keywords: NodeList IE Cc: James Burke
Blocked By: Blocking:

Description

a.constructor === NodeList

fails in IE7.0.5730.13
Propose

(typeof(NodeList)!="undefined" && a.constructor === NodeList)

Attachments (2)

nodelist_concat.patch (729 bytes) - added by Adam Peller 10 years ago.
Patch from John Ryding (IBM, CCLA)
nodelist_undefined_concat_tests.diff (850 bytes) - added by Adam Peller 10 years ago.
additional tests from John Ryding

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by dante

Cc: James Burke added
Owner: changed from anonymous to Eugene Lazutkin

seems like I've seen that a.constructor == NodeList? checkin NodeList?.js -- is this still an issue?

comment:2 Changed 10 years ago by Eugene Lazutkin

Milestone: tbd1.4

Changed 10 years ago by Adam Peller

Attachment: nodelist_concat.patch added

Patch from John Ryding (IBM, CCLA)

comment:3 Changed 10 years ago by Adam Peller

Summary: IE7 failed dojo._base.NodeList.concat[patch]IE7 failed dojo._base.NodeList.concat

What's the test case and is it in the test suite?

Changed 10 years ago by Adam Peller

additional tests from John Ryding

comment:4 Changed 10 years ago by bill

Summary: [patch]IE7 failed dojo._base.NodeList.concat[patch] [ccla] IE7 failed dojo._base.NodeList.concat

comment:5 Changed 10 years ago by Eugene Lazutkin

Resolution: fixed
Status: newclosed

(In [20667]) Comitting a patch to NodeList?.concat(), thx John Ryding (IBM, CCLA)!, !strict, fixes #9337.

Note: See TracTickets for help on using tickets.