ItemFileReadStore: deserialize fails when _value = 0

[drcoelho]

If a value _value is set to 0, the deserialize function is not called properly, and an invalid deserialized value is returned. In a grid, instead of getting a deserialized value, one would get '[object Object]' displayed.

dojo/data/ItemFileReadStore.js has the following test:

if (value._type && value._value) { ...

which should be changed to:

if (value._type !== null && value._value !== null) { ...

to avoid bypass of deserialize call when _value=0. Diff of changes required to fix this bug are included in attachment.

[drcoelho]

diff for ItemFileReadStore?.js showing patch to fix bug

[Jared Jurkiewicz]

Actually, the checks should be !=, so that both null and undefined are caught.

[Jared Jurkiewicz]

Actually, there's a better check, such as (if ((_type in value) && (_value in value)), which makes sure they're defined and can have any value. Need to experiment with these and pick one.

[Jared Jurkiewicz]

Added a patch that lets _value be anything from explicit undefined, null, 0, false, "", etc, without causing a problem with it deserializing. Added in UT for it as well.

[Jared Jurkiewicz]

(In [17606]) Adding in better custom type deserialization + UT. \!strict (Also added in UT for #9322) refs #9332

[Jared Jurkiewicz]

(In [17607]) Adding in better custom type deserialization + UT. Forgot a debug console. Removed \!strict refs #9332

[Jared Jurkiewicz]

(In [17608]) Adding in better custom type deserialization + UT. \!strict refs #9332

[Jared Jurkiewicz]

Tested on:

FF3

IE7

Safari 3.2.3

Opera 9.62

[Jared Jurkiewicz]

Note you will also want fixes from: #9322