Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#933 closed enhancement (fixed)

combobox select arrow patch

Reported by: jkuhnert@… Owned by: anonymous
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

Supplied patch changes the behaviour of the ComboBox?(or select..whatever) such that if you hit the down arrow it forces a full population of the options list. This makes the most sense imho as the ComboBox? is making itself "look" like a select but not behaving the same way in one very key portion, which is pulling down a list.

I would argue that the only scenerio where the current default functionality is valid is with an "Autocompleter" sort of searchable/filterable text field. This patch satisfies both needs as manual text typing still filters the searches appropriately.

Attachments (1)

dojo-combobox-patch.txt (569 bytes) - added by jkuhnert@… 13 years ago.
the patch

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by jkuhnert@…

Attachment: dojo-combobox-patch.txt added

the patch

comment:1 Changed 13 years ago by bill

Milestone: 0.3.10.4

Jesse, even with the current code, if you press the down arrow without typing anything into the field first, the selection list is fully populated, right? What is the issue exactly?

comment:2 Changed 13 years ago by jkuhnert@…

Milestone: 0.40.3.1

The issue only comes up ~after~ you've selected something. In that scenerio clicking the down arrow only gives you a list of the item you have already selected. I thought long and hard about this one, but I can't find a scenerio in my head where a user would want the selection list to appear with only their current selection when clicking it. Can you?

comment:3 Changed 13 years ago by jkuhnert@…

Milestone: 0.3.10.4

Oops...Trac auto-selected milestone 0.3.1 for me, I wasn't changing it back to that on purpose..

comment:4 Changed 13 years ago by bill

Resolution: fixed
Status: newclosed

OK, I guess that makes sense. Checked in change [4402]. Hope it's not controversial.

comment:5 Changed 13 years ago by jkuhnert@…

Hooray! Someone else told me they weren't sure about it, but feel free to point anyone with a problem with it at me and I'll try my best to justify my thinking.

comment:6 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.