Opened 10 years ago

Closed 10 years ago

#9317 closed enhancement (fixed)

Add isSelectedDate to dijit._Calendar

Reported by: ryangroth5 Owned by: bill
Priority: high Milestone: 1.4
Component: Dijit Version: 1.3.0
Keywords: date select calendar Cc: dojo@…
Blocked By: Blocking:

Description

There is a basic assumption that the _Calendar has one selected date which limits the ability to select multiple dates on the _Calendar. While this might be an uncommon case for the dijit.* components, it is an requirement to facilitate with the addition of one method.

Please review the following patch and if it doesn't seem to violate any design principles the additional capability that subclasses could provide would be beneficial to the community. I actually think that it improves the readability of the code as well.

I have a CLA on file if you want to incorporate the patch as is.

Attachments (1)

dijit.diff (739 bytes) - added by ryangroth5 10 years ago.
adds isSelectedDate to _Calendar

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by ryangroth5

Attachment: dijit.diff added

adds isSelectedDate to _Calendar

comment:1 Changed 10 years ago by bill

Owner: set to bill
Status: newassigned

OK, I'll add it but as _isSelectedDate since it's not a typical extension function (ie, it only makes sense if you are subclassing Calendar, it doesn't make sense to just define that one method).

comment:2 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [17544]) Make it possible to subclass _Calendar to have multiple selected dates. Fixes #9317 !strict.

Note: See TracTickets for help on using tickets.