Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#931 closed defect (fixed)

Editor2: undo doesn't work (IE)

Reported by: bill Owned by: liucougar
Priority: high Milestone:
Component: General Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

Tested on test_Editor2.html on IE.

If you just type in some text on the first editor and hit the undo button, nothing happens.

Attachments (1)

931.patch (1.5 KB) - added by liucougar 13 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by liucougar

Owner: changed from alex to liucougar

As suggested in http://blog.metawrap.com/blog/MicrosoftsEolasActiveXPatchForIESometimesBreaksJavaScriptWorkaround.aspx, after removing windows update KB912945, the editor2 widget works fine, and undo functions normally

Will investigate how to prevent the editor failure with that patch installed

comment:2 Changed 13 years ago by liucougar

Status: newassigned

In order to work around the problem when that offending patch is installed, a new function has to be introduced:

according to http://msdn.microsoft.com/library/default.asp?url=/workshop/author/dhtml/overview/activating_activex.asp

the function to create the embedded ActiveX object has to be defined in an external js file (included via a script tag). However, if it is defined in a file other than dojo.js, which get included via dojo.js, IE still requires the user to activate ActiveX object before using.

So I have to add the function createExternalElement in dojo.js itself. However, as it only contains 3 lines, I think it should be ok.

In addition, I added another function in dojo.js, loadExternalScript, to replace the not-so-decent line: document.write("<scr"+"ipt type='text/javascript' src='"+spath+"'></scr"+"ipt>");

Any objections for this patch to be merged?

Changed 13 years ago by liucougar

Attachment: 931.patch added

comment:3 Changed 13 years ago by liucougar

the activeX issue is fixed in r4959

comment:4 Changed 13 years ago by alex

Resolution: fixed
Status: assignedclosed

the remaining non-activex issues if fixed in [5038]

comment:5 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.