Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9304 closed defect (fixed)

execute is called twice on dijit.TooltipDialog when submit button is pressed with space bar

Reported by: ben hockey Owned by: Becky Gibson
Priority: high Milestone: 1.4
Component: Accessibility Version: 1.3.1
Keywords: Cc:
Blocked By: Blocking:

Description

go to http://download.dojotoolkit.org/release-1.3.1/dojo-release-1.3.1/dijit/tests/test_TooltipDialog.html and click on the first drop down "Show Tooltip Dialog" then tab to the "Order" button and press space. on ff 3.0.10 on mac, the execute is fired twice. on safari 3.2.1 it only fires once.

Change History (4)

comment:1 Changed 10 years ago by ben hockey

the same issue happens with the dialog test page http://download.dojotoolkit.org/release-1.3.1/dojo-release-1.3.1/dijit/tests/test_Dialog.html this might suggest that it's probably related to the button or the form rather than the dialog.

comment:2 Changed 10 years ago by bill

Component: DijitAccessibility
Owner: set to Becky Gibson

Yes, the Dialog problem is already reported in #9156.

comment:3 Changed 10 years ago by Becky Gibson

Resolution: fixed
Status: newclosed

(In [17832]) fixes #8879, #8946, #8951, #8978, #8979, #9304, #9156 rework of ondijitclick event handler. Perform action only on keyup of enter or space. Track object that receives keydown and only invoke action on keyup when target matches the keydown object. Do not use ondijitclick for elements that already have onclick support for enter and space key press (button, links) or when that onclick event will bubble up to a parent element. Thus, changed button and combobutton templates to use onclick rather than ondijitclick. No longer need special case for submit and reset buttons in button.js _onButtonClick(). Updated button_a11y.html test file to include test of submit and reset buttons. Updated widget-ondijitclick.html to again include space and enter key testing. !strict

comment:4 Changed 10 years ago by Adam Peller

Milestone: tbd1.4
Note: See TracTickets for help on using tickets.