Opened 10 years ago

Closed 10 years ago

#9302 closed defect (fixed)

onAnimate is fired once after onEnd in a combined animation

Reported by: nic Owned by: Eugene Lazutkin
Priority: high Milestone: 1.4
Component: fx Version: 1.3.0
Keywords: onAnimate fx Cc: dante
Blocked By: Blocking:

Description

dojo.fx.combine creates a _pseudoAnimation independent of the original anims: _pseudoAnimation can fire onAnimate if step >= 1 (dojo/fx.js) even if the partial animation has already fired onEnd. Test case and proposed patch attached

Attachments (2)

fx.js.diff​ (430 bytes) - added by nic 10 years ago.
combined.html​ (1.1 KB) - added by Eugene Lazutkin 10 years ago.
modified test file

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by nic

Attachment: fx.js.diff​ added

comment:1 Changed 10 years ago by nic

Cc: dante added

comment:2 Changed 10 years ago by nic

Ignore the patch to dojo/_base/fx.js: as Peter said, removing the last t._fire("onAnimate",... the original animation isn't completed.

comment:3 Changed 10 years ago by Eugene Lazutkin

Owner: changed from Bryan Forbes to Eugene Lazutkin
Status: new → assigned

comment:4 Changed 10 years ago by Eugene Lazutkin

Milestone: tbd → 1.4

Excellent test case!

Changed 10 years ago by Eugene Lazutkin

Attachment: combined.html​ added

modified test file

comment:5 Changed 10 years ago by Eugene Lazutkin

Resolution: → fixed
Status: assigned → closed

(In [17930]) fx: fixing a minor bug in dojo.fx.combine(), !strict, fixes #9302.

Note: See TracTickets for help on using tickets.