#9289 closed enhancement (fixed)
Adding the original event to the onClick call in Tree widget
Reported by: | genro | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | Dijit | Version: | 1.3.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
I am suggesting here to add the parameter 'event' to the onClick call in the Tree widget as in many circumstances the user interface could use the event modifiers to perform a more specific action. So for example a Shift click on a tree item could act differently than a pure click or an alt + click. It can be easily implemented to dijit Tree with the following changes :
line 882:
- this.onClick(nodeWidget.item, nodeWidget);
+ this.onClick(nodeWidget.item, nodeWidget, e);
line 929
- onClick: function(/* dojo.data */ item, /*TreeNode?*/ node)
+ onClick: function(/* dojo.data */ item, /*TreeNode?*/ node,/*Event*/ e)
The same type of behavior could be implemented also for DblClick? and in a more general way when Dijit wraps an event it should pass the original event to the wrapper to allow a better tuning of the interface. So maybe it could be useful also for other widgets.
Thank you
Giovanni Porcari
Change History (3)
comment:1 Changed 13 years ago by
Milestone: | tbd → 1.4 |
---|---|
Owner: | set to bill |
Status: | new → assigned |
I checked the other widgets and most/all of them are passing the event already, but I'll update Tree to do so too.