Opened 10 years ago

Closed 7 years ago

#9237 closed defect (fixed)

[patch][cla]DataGrid Bool click discards same row in-progress edit

Reported by: Frank Fortson Owned by: Frank Fortson
Priority: high Milestone: 1.4
Component: DojoX Grid Version: 1.3.0
Keywords: DataGrid Bool cancel edit Cc: frank.fortson@…
Blocked By: Blocking:

Description

The problem can be seen when you click directly (not in the area within the cell surrounding the checkbox) on a checkbox (dojox.grid.cells.Bool) while another cell in that same row is in edit mode. The change made in the in-progress edit is discarded, as if a cancelEdit had been applied.

However, if you click on a checkbox in a different row or click on another cell in any row, the edit is saved.

This problem may also occur in other "AlwaysEdit?" widgets within a DataGrid?.

In this file:

http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_edit.html

double click a cell in the Status column and change the Select's value from its current value to a new value. Then, click the adjacent checkbox in the Mark column. The checkbox state will change, but the Status cell value reverts to the original value, as if a cancelEdit occurred.

Do the above test, but make the second click in any other non-checkbox cell in any row OR make the second click in any checkbox in a different row, and the Status edit change is accepted, not discarded.

A patch is attached that seems to fix the problem. However, a more elegant fix should be available.

Attachments (1)

dojox.grid.cells._base.js.patch (525 bytes) - added by Frank Fortson 10 years ago.
Possible patch for DataGrid? Bool click and discard in-progress edit.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Frank Fortson

Possible patch for DataGrid? Bool click and discard in-progress edit.

comment:1 Changed 10 years ago by kandersen

Still experiencing this with version 1.3.2. Our research has shown that the onApplyCellEdit event is running on the Bool cell before the cell that is currently in edit mode. We tried forcing an apply first in our event code but the data is already changed at that point (as described above as if a cancelEdit was issued). The patch does not appear to be helping this version. Is there a status on when this might be addressed?

comment:2 Changed 7 years ago by ben hockey

Owner: changed from Bryan Forbes to Frank Fortson
Status: newpending

i don't see this issue in dojo 1.7. frankf if this is still a problem then please respond. if there is no response within 14 days, this ticket will automatically close.

comment:3 Changed 7 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

comment:4 Changed 7 years ago by bill

Resolution: invalid
Status: closedreopened

I confirm this as broken in 1.3, but fixed in 1.4, marking as such.

comment:5 Changed 7 years ago by bill

Milestone: tbd1.4
Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.