Changes between Initial Version and Version 1 of Ticket #9213


Ignore:
Timestamp:
Apr 28, 2009, 10:12:59 AM (11 years ago)
Author:
bill
Comment:

Hi, thanks for the patch but a few things:

1) we can't look at the patch unless you've filed a CLA; I guess you are from IBM? They have a CLA already.

2) you should attach patches as .diff/.patch files showing the changes that you made to the file

3) You've modified the build version not the source version, hence it has weird stuff like _2 and _3 that won't let us merge; need to build a patch against the source version.

4) We have an NLS infrastructure in dojo to load language strings from NLS files, rather than hardcoding them in the JS

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9213 – Description

    initial v1  
    77
    88**************************************************************************************
    9 
     9{{{
    1010var _2=function(_3){
    1111return _3;
     
    6363\n",postCreate:function(){
    6464this.inherited(arguments);
     65}}}
    6566
    6667**************************************************************************************
     
    6970
    7071**************************************************************************************
    71 
     72{{{
    7273.dojoxColorPicker {
    7374padding:8px;
     
    7980-webkit-border-radius:5pt;
    8081}
     82}}}