Opened 10 years ago

Closed 10 years ago

#9196 closed defect (fixed)

dijit._editor.plugins.LinkDialog adds unneeded closing img tag

Reported by: vovasty Owned by: bill
Priority: low Milestone: 1.4
Component: Editor Version: 1.3.0
Keywords: Cc:
Blocked By: Blocking:

Description

Inserting image will produce html 

<img src='/path/to/img' _djrealurl='/path/to/img' alt='image alt'></img>

resulting html in IE6 will produce junk (/>) at end of image.

Attached patch has a solution to this problem

Attachments (1)

LinkDialog.patch​ (705 bytes) - added by vovasty 10 years ago.

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by vovasty

Attachment: LinkDialog.patch​ added

comment:1 Changed 10 years ago by bill

Milestone: tbd → 1.4
Owner: changed from liucougar to bill
Status: new → assigned

Looks good. My only worry is whether any browsers will choke on a /> for closing a tag but that's how we do images in our templates so I guess it's OK. I'll check it in.

W/out this change the markup produced by IE (on Editor.getValue()) is <img ... /> </img />)

comment:2 Changed 10 years ago by bill

Resolution: → fixed
Status: assigned → closed

(In [17432]) Fix markup returned by Editor.getValue() for images. Fixes #9196 !strict.

Note: See TracTickets for help on using tickets.