Opened 13 years ago
Closed 13 years ago
#9183 closed defect (fixed)
Remove dojo.isFF references
Reported by: | Adam Peller | Owned by: | Adam Peller |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | General | Version: | 1.3.0 |
Keywords: | Cc: | James Burke, dante, Becky Gibson | |
Blocked By: | Blocking: |
Description (last modified by )
While we can't remove isFF itself or even deprecate it, we need to replace FF checks with Gecko version checks (or perhaps isMoz?) much like we did for Safari/Firefox? (#7845) Firefox versions aren't really relevant, and other variants will break. Iceweasel stubbornly uses their own UA string as do Mozilla's new nightlies for 3.5, etc.
Where possible, of course, we should eliminate UA sniffing entirely. see #8947
Attachments (1)
Change History (24)
comment:1 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 13 years ago by
comment:5 Changed 13 years ago by
Owner: | changed from anonymous to James Burke |
---|
Taking this to convert the couple of references in core, but will then punt the ticket to future and assign it back to anonymous.
comment:6 Changed 13 years ago by
There are 50 matches of dojo.isFF across the codebase, 27 in dojox, 5 in dojo and 18 in dijit. I can change the dijit references from isFF to isMoz although I'm not going to test it except for FF.
comment:7 Changed 13 years ago by
comment:8 Changed 13 years ago by
FF2 is being removed across the board, see [20357]. So there isn't currently any need for version checking.
comment:9 Changed 13 years ago by
comment:10 Changed 13 years ago by
comment:11 Changed 13 years ago by
Milestone: | 1.4 → future |
---|---|
Owner: | changed from James Burke to anonymous |
I consider this ticket done for Core, pushing it out to future for dijit/dojox use.
comment:12 Changed 13 years ago by
Owner: | changed from anonymous to Adam Peller |
---|
Dijit is done too, it's just dojox.
Changed 13 years ago by
Attachment: | 9183_remove_isFF_references.diff added |
---|
Patch from John Ryding (IBM,CCLA) to remove isFF references in dojox, with some minor tweaks from me
comment:13 follow-up: 18 Changed 13 years ago by
Cc: | Becky Gibson added |
---|
Becky, we still have some FF<3 conditionals around aria stuff in dijit and dojox. Are we ditching that also?
comment:14 Changed 13 years ago by
Milestone: | future → 1.4 |
---|
comment:15 Changed 13 years ago by
comment:16 Changed 13 years ago by
@jburke, in the event we do need to resort to UA sniffing going forward for particular browser versions, were we going to use gecko version numbers instead? dojo.isGecko?
comment:17 Changed 13 years ago by
peller; perhaps, but the isGecko version number code I had in before was faulty. I would like to see how far we can get before needing it.
comment:18 Changed 13 years ago by
Replying to peller:
Becky, we still have some FF<3 conditionals around aria stuff in dijit and dojox. Are we ditching that also?
Adam, are you sure about dijit? I searched all of dijit, and there are no dojo.isFF references anywhere, except of course for sniff.js. Not even any "isFF" references. I suspect you were looking at old code.
I do see the code in dojox, looks like it's all for FF2 support so it can just be removed (referencing #4614). Maybe John can do that too.
comment:19 Changed 13 years ago by
comment:23 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
See also #4614, about desupporting FF2. Doing that first means less work on this ticket, although it's no big deal either way.