Remove dojo.isFF references

[Adam Peller]

While we can't remove isFF itself or even deprecate it, we need to replace FF checks with Gecko version checks (or perhaps isMoz?) much like we did for Safari/Firefox? (#7845) Firefox versions aren't really relevant, and other variants will break. Iceweasel stubbornly uses their own UA string as do Mozilla's new nightlies for 3.5, etc.

Where possible, of course, we should eliminate UA sniffing entirely. see #8947

[bill]

See also #4614, about desupporting FF2. Doing that first means less work on this ticket, although it's no big deal either way.

[Adam Peller]

(In [17389]) remove unneeded isFF condition. Refs #9183

[Adam Peller]

May also be an issue with XULRunner

[James Burke]

Taking this to convert the couple of references in core, but will then punt the ticket to future and assign it back to anonymous.

[bill]

There are 50 matches of dojo.isFF across the codebase, 27 in dojox, 5 in dojo and 18 in dijit. I can change the dijit references from isFF to isMoz although I'm not going to test it except for FF.

[Adam Peller]

I thought a lot of the remaining isFF references were for a specific version. For FF2, are we removing them all in 1.4 or just for Dijit? (See #4614) Where Firefox version checks are necessary, I suppose the alternative would be to check against a gecko #.

See also #8894

[bill]

FF2 is being removed across the board, see [20357]. So there isn't currently any need for version checking.

[bill]

(In [20393]) Remove FF2 references from tests (refs #4614), and change remaining dijit FF checks to use dojo.isMoz rather than dojo.isFF (refs #9183).

[James Burke]

(In [20399]) Refs #9183, changing last isFF references to isMoz for Core. there is one isFF reference still in use, but it is to specifically detect for a bug specific to FF 3. \!strict

[James Burke]

I consider this ticket done for Core, pushing it out to future for dijit/dojox use.

[bill]

Dijit is done too, it's just dojox.

[Adam Peller]

Patch from John Ryding (IBM,CCLA) to remove isFF references in dojox, with some minor tweaks from me

[Adam Peller]

Becky, we still have some FF<3 conditionals around aria stuff in dijit and dojox. Are we ditching that also?

[Adam Peller]

(In [20416]) Remove more isFF references. Replace with isMoz, for now. Thanks, John Ryding. Refs #9183 !strict

[Adam Peller]

@jburke, in the event we do need to resort to UA sniffing going forward for particular browser versions, were we going to use gecko version numbers instead? dojo.isGecko?

[James Burke]

peller; perhaps, but the isGecko version number code I had in before was faulty. I would like to see how far we can get before needing it.

[bill]

Replying to peller:

Becky, we still have some FF<3 conditionals around aria stuff in dijit and dojox. Are we ditching that also?

Adam, are you sure about dijit? I searched all of dijit, and there are no dojo.isFF references anywhere, except of course for sniff.js. Not even any "isFF" references. I suspect you were looking at old code.

I do see the code in dojox, looks like it's all for FF2 support so it can just be removed (referencing #4614). Maybe John can do that too.

[Adam Peller]

(In [20427]) remove isFF in comment just so it won't show up in searches anymore. Refs #9183

[Adam Peller]

(In [20429]) Remove FF2 support. Refs #9183, #6946

[Adam Peller]

(In [20431]) Remove FF2 support. Refs #9183, #8864

[Adam Peller]

(In [20433]) Remove FF2 support. Refs #9183 !strict