Opened 11 years ago
Closed 10 years ago
#9165 closed enhancement (fixed)
Add a preview feature to the ExpandoPane
| Reported by: | Shane O'Sullivan | Owned by: | Shane O'Sullivan |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5 |
| Component: | DojoX Widgets | Version: | 1.3.0 |
| Keywords: | Cc: | jbarzilai, spidey2099 | |
| Blocked By: | Blocking: |
Description
A very useful feature of ExpandoPane?-like widgets is the ability to "preview" their contents, without having to update the rest of the layout.
When the expand icon is clicked, the widget would open or contract as usual. However if the "bar" of the widget is clicked, the contents slide out without moving the rest of the layout. Clicking the bar again slides it back in.
This is very useful for menu-like widgets, or trees, that appear to the left or the right of a border container.
Attachments (2)
Change History (13)
comment:1 Changed 10 years ago by
| Cc: | jbarzilai added; dante removed |
|---|---|
| Status: | new → assigned |
comment:2 Changed 10 years ago by
| Milestone: | tbd → 1.4 |
|---|
Changed 10 years ago by
| Attachment: | expando-preview.patch added |
|---|
comment:3 Changed 10 years ago by
| Cc: | spidey2099 added |
|---|
RFC: Attached is an initial patch. Double-click to preview, exposed public api "preview" to allow wiring, retains original behavior 100% (except in test, to test) with one big caveat: when the pane is previewed, and the parent BC resizes, the node turns from a preview to a placed pane (layout trickles). Would love feedback.
comment:4 Changed 10 years ago by
| Milestone: | 1.4 → 1.5 |
|---|
comment:5 Changed 10 years ago by
Is there no way that this can make it into 1.4? It's a very useful feature, and shouldn't be very difficult to implement.
comment:6 Changed 10 years ago by
I attached a patch, and explained some caveats and made a RFC, no one spoke up. Today is enhancement cutoff. Test the patch, see how it goes for you. Perhaps update with less breaking, I'm blocked on the BC -> other splitter causes pane to go from preview -> fixed
comment:7 Changed 10 years ago by
Thanks for writing up the patch Pete. Is the issue with the splitter changing the preview to fixed really an issue? That behaviour would make sense to me.
The only issue I see with this patch is that after the user has dragged a splitter and caused the preview to become fixed, collapsing the pane again does not cause the BC to layout. I'm attaching an updated patch that fixes this issue.
Changed 10 years ago by
| Attachment: | expando-preview2.patch added |
|---|
Fixes layout issue after splitter dragged
comment:8 Changed 10 years ago by
Pete, is it ok to put this one through? I've tested it locally and it seems to work well. Do you have any reservations about it?
comment:9 Changed 10 years ago by
| Owner: | changed from dante to Shane O'Sullivan |
|---|---|
| Status: | assigned → new |
+1 shane.
comment:10 Changed 10 years ago by
(In [22055]) Refs #9165 Adds an optional preview feature to the ExpandoPane?, where on double click the pane will slide out but not cause a layout call on the border container. Thanks to Pete Higgins for implementing it. !strict
comment:11 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Added this feature in [22055], closing.
I hope to get this in soon. I've been prodded enough.