Opened 11 years ago

Closed 11 years ago

#9156 closed defect (fixed)

Dialog execute function called twice on keyboard click

Reported by: djhutch Owned by: Becky Gibson
Priority: high Milestone: 1.4
Component: Accessibility Version: 1.3.0
Keywords: Cc:
Blocked By: Blocking:

Description

In a dialog, when I tab to the submit button and press the Enter key, the execute function of the dialog gets called twice. If I just click on the submit button it correctly calls the execute function only once. I've seen this behavior in both Firefox 3 and IE 7.

Change History (4)

comment:1 Changed 11 years ago by bill

Component: DijitAccessibility
Milestone: tbd1.4
Owner: set to Becky Gibson
Summary: Dialog execute function called twiceDialog execute function called twice on keyboard click

Can you attach a testcase? Becky is going to be revamping ondijitclick so hopefully this issue will be addressed w/that.

comment:3 Changed 11 years ago by Becky Gibson

Priority: normalhigh

comment:4 Changed 11 years ago by Becky Gibson

Resolution: fixed
Status: newclosed

(In [17832]) fixes #8879, #8946, #8951, #8978, #8979, #9304, #9156 rework of ondijitclick event handler. Perform action only on keyup of enter or space. Track object that receives keydown and only invoke action on keyup when target matches the keydown object. Do not use ondijitclick for elements that already have onclick support for enter and space key press (button, links) or when that onclick event will bubble up to a parent element. Thus, changed button and combobutton templates to use onclick rather than ondijitclick. No longer need special case for submit and reset buttons in button.js _onButtonClick(). Updated button_a11y.html test file to include test of submit and reset buttons. Updated widget-ondijitclick.html to again include space and enter key testing. !strict

Note: See TracTickets for help on using tickets.