Opened 11 years ago

Closed 7 years ago

#9144 closed defect (patchwelcome)

Grid: Down and Up Arrows Stop Working in IE 6

Reported by: anthonywatson Owned by: Bryan Forbes
Priority: high Milestone: future
Component: DojoX Grid Version: 1.3.0
Keywords: Grid 13 Cc: Nathan Toone, Becky Gibson
Blocked By: Blocking:

Description

The is an issue with using the down and up arrows in the grid in IE 6. If I click on a grid row, then hit the down arrow once, it will move the focus to the row below, as it should. However, if I hit the down arrow again, nothing happens. It appears as though the events aren't getting through. Once the down and up keys stop working, I can get them working again permanently by clicking on another row in the grid. I was able to hack up a fix that should help to guide whoever works on this. In the code I uploaded, I substituted my own 'onKeyDown' function. The only difference between my version and the normal version of this function is that I changed the code for the down and up arrow keys. I have tested it and my fix prevents the down and up arrows from failing as I described above.

Please note that whoever tests this will need to change the Dojo url in my document which I marked with ${dojoHomeURL_1_3}

Attachments (1)

dojoGridHightlightSimple.html (10.6 KB) - added by anthonywatson 11 years ago.

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by anthonywatson

comment:1 Changed 11 years ago by Adam Peller

Cc: Nathan Toone Becky Gibson added
Component: GeneralDojoX Grid
Keywords: 13 added
Owner: changed from anonymous to Bryan Forbes

comment:2 Changed 11 years ago by Becky Gibson

I don't see this in the April 17, 2009 nightly. There is a problem in IE6 where the focus border is not visible when using the tundra theme. But, if I tab into the data and press enter, I see the row get selected. If I press down arrow again, then press enter to select the row, the next row is selected. Thus, the arrow keys do seem to be working but the problem is really that there is no visible indication of focus.

comment:3 in reply to:  2 Changed 11 years ago by anthonywatson

Replying to becky:

I don't see this in the April 17, 2009 nightly. There is a problem in IE6 where the focus border is not visible when using the tundra theme. But, if I tab into the data and press enter, I see the row get selected. If I press down arrow again, then press enter to select the row, the next row is selected. Thus, the arrow keys do seem to be working but the problem is really that there is no visible indication of focus.

The bug is subtle. Note that I describe clicking on the grid to give the grid row the focus. In contrast, Becky describes tabbing into the grid.

comment:4 Changed 11 years ago by Becky Gibson

ok, thanks for the clarification. Although, I do believe we want to continue to use the move function rather than just calling setFocusIndex() directly.

comment:5 Changed 10 years ago by Adam Peller

Owner: changed from Bryan Forbes to Becky Gibson

bump

comment:6 Changed 10 years ago by Becky Gibson

Milestone: tbdfuture

comment:7 Changed 9 years ago by Chris Mitchell

Owner: changed from Becky Gibson to Bryan Forbes

reassign due to inactive committer. please triage accordingly.

comment:8 Changed 7 years ago by bill

DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:9 Changed 7 years ago by bill

Resolution: patchwelcome
Status: newclosed
Note: See TracTickets for help on using tickets.