MenuBar: Runtime Error in Menu.js when moving cursor to menu item w/no popup

[Yves De Bruyne]

In the function _openPopup, when hovering over a MenuBarItem, you get an error because the item in question has no 'popup' object.

I solved this locally by adding an additional check

[Menu.js]

162		var popup = from_item.popup;

+++		if (!popup) { return; }

164		if(popup.isShowingNow){ return; }

Not sure if this is the right solution or if MenuBarItem is derived from the wrong class...

[bill]

Can you give a test case or steps to reproduce in ​test_Menu.html?

I've hovered over MenuBarItem's before with no problems.

Which browser?

[Yves De Bruyne]

I've not been able to reproduce it on the test_Menu.

I've attached a simple version of my code (really tiny). I get a JavaScript? error when I open the "Directories" Submenu, then move to "Web Mail" item.

I've tried this on Firefox 3 and Internet Explorer7.

[bill]

OK, thanks for the test case. Not sure if this is the cause of your problem, but why are you adding a MenuBarItem widget to a Menu?

pMetaMenu.addChild(new dijit.MenuBarItem({
    ...

That's invalid.

[Yves De Bruyne]

Refactored names to make example clearer

[Yves De Bruyne]

I'm not sure I do... I reuploaded the file with new variable names to clear up the confusion... I took it almost verbatim out of my project before...

1) Create Menubar 2) Create Submenu 3) Add Item so the submenu

4) Add submenu to the Menubar 5) Add plain item to the menubar

Still stuggling with the docs though... My project has moved to using the parser to instantiate the menu, but I'd like to nail down this error so I can sleep at night :-)

Cheers

[bill]

Ah OK I see it now.

The problem happens when the user is hovering over a menu item with a sub-menu (that is open), and then the user moves the cursor over a menu item w/out a submenu.

Thanks for the test case and the bug report. I'll fix.

[bill]

(In [17311]) Don't try to automatically open the sub-menu for a MenuBarItem? w/out a sub-menu. Fixes #9140 !strict.