Opened 12 years ago
Closed 8 years ago
#9122 closed defect (invalid)
[patch] [cla] dojox.grid.DataGrid: setStore doesn't resize the grid if there are no items in the store
Reported by: | msmith | Owned by: | msmith |
---|---|---|---|
Priority: | high | Milestone: | future |
Component: | DojoX Grid | Version: | 1.3.0 |
Keywords: | DataGrid resize setStore | Cc: | |
Blocked By: | Blocking: |
Description
Using the setStore() function in the Grid is very handy to refresh the Grid with new data. In the event that the new data does not contain any items, the DataGrid? will display the NoDataMessage? below the existing div node for the Views. Re-rendering the views and calling the private _resize() function addresses the issue. Please see the attached patch.
It's been a while since I've submitted a patch, so if it's not quite the right format, please let me know.
Attachments (1)
Change History (8)
Changed 12 years ago by
Attachment: | DataGridSetStore.patch added |
---|
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Milestone: | tbd → 1.5 |
---|---|
Owner: | changed from Bryan Forbes to Nathan Toone |
The previous commit addresses the empty store issue - however, there are still issues if you try to switch stores while the slow-loading-store is loading, as well as if you choose the error store (it appears you can't change any store after setting the error store).
comment:3 Changed 11 years ago by
comment:4 Changed 11 years ago by
The previous patch addresses the changing of the store after setting the error store. The only remaining problem is if you switch stores during a slow-loading-store load.
comment:5 Changed 11 years ago by
Milestone: | 1.5 → future |
---|---|
Owner: | Nathan Toone deleted |
Moving my tickets to future, as I am not currently working on them.
comment:6 Changed 8 years ago by
Owner: | set to msmith |
---|---|
Status: | new → pending |
I am afraid this patch is horribly stale. If still interested in this patch and if it is still needed, if you could update it against trunk and resubmit.
comment:7 Changed 8 years ago by
Resolution: | → invalid |
---|---|
Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
Patch file with unit tests