Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9118 closed defect (fixed)

unnecessary check for this.store in down arrow key process breaks keyboard nav. in some grids

Reported by: Becky Gibson Owned by: Bryan Forbes
Priority: high Milestone: 1.4
Component: DojoX Grid Version: 1.3.0
Keywords: a11y Cc: Becky Gibson
Blocked By: Blocking:

Description

#7463 modified the grid down arrow key handling to refer to this.rowCount rather than this.store.count. Thus, the check that this.store in the if clause below is no longer necessary.

case dk.DOWN_ARROW:

if(!this.edit.isEditing() && this.store && this.focus.rowIndex+1 != this.rowCount){

dojo.stopEvent(e); this.focus.move(1, 0);

} break;

I'm setting this to high priority as it breaks keyboard navigation in some grid instances.

Change History (2)

comment:1 Changed 10 years ago by Becky Gibson

Resolution: fixed
Status: newclosed

closed via changeset [17504] (cut and paste error of ixes instead of fixes killed the auto close)

comment:2 Changed 10 years ago by Becky Gibson

Milestone: tbd1.4
Note: See TracTickets for help on using tickets.