#9107 closed defect (wontfix)
TimeTextBox fails for some timezones using Firefox on nonWindows
| Reported by: | Douglas Hays | Owned by: | Douglas Hays |
|---|---|---|---|
| Priority: | high | Milestone: | 1.7 |
| Component: | Dijit - Form | Version: | 1.3.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
I'm testing on Mac OS/X and using Firefox 3. Set the timezone to anything east of GMT (I selected BST). Run test_TimeTextBox.html and click the textbox labeled "24 Hour Time with 1 Hour TimePicker?". The time intervals will be > 1 hour but should be 15 minutes. This seems to work OK on Windows. Fails on Ubuntu as well. The problem is that a date of Jan 1, 1970 is used by dojo.date.stamp.fromISOString, but midnight in BST (passed to the method) is a negative time relative to midnight GMT and thus bad things happen.
Attachments (1)
Change History (13)
comment:1 Changed 12 years ago by
| Cc: | Adam Peller added |
|---|
comment:2 Changed 12 years ago by
filed a ticket against Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=487897
Changed 12 years ago by
| Attachment: | 9107.patch added |
|---|
workaround to fromISOstring returning incorrect Date objects
comment:3 Changed 12 years ago by
| Cc: | Adam Peller removed |
|---|---|
| Owner: | changed from Douglas Hays to Adam Peller |
Entering 12:30 AM manually in the TimeTextBox? calls dojo.date.locale.parse which returns a Date object containing 1:30AM, so a dijit workaround is insufficient. Short of getting a fix from Firefox, either changing the default date to Jan 2, 1970 in both dojo and dijit, or just changing it for timezones east of GMT (more code, less impact), may be the only options to fix this. I guess it's also possible that if parse adds an additional defaultDate parameter similar to fromISOstring that dijit's TimeTextBox? could make use of this.
comment:5 Changed 12 years ago by
| Milestone: | tbd → future |
|---|
comment:6 Changed 11 years ago by
| Milestone: | future → tbd |
|---|
comment:7 Changed 11 years ago by
is there a related daylight savings issue here for TimeTextBox?, in general? Without specifying a date, the timezone is going to be wrong half the time where daylight savings is observed.
comment:9 Changed 10 years ago by
| Component: | Dijit → Dijit - Form |
|---|---|
| Owner: | set to Douglas Hays |
comment:10 Changed 10 years ago by
| Milestone: | tbd → 1.8 |
|---|
comment:11 Changed 9 years ago by
| Milestone: | 1.8 → 1.7 |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
I tried this on OSX 10.6.8 using FF 4.0 + Dojo 1.7.0 with timezone=GMT+0100 (Madrid, Spain) and it's working OK. If there's another specific timezone that fails, then it's probably a wontfix.
fromISOstring calls new Date(1970, 0, 1, 0, 15, 0, 0) for T00:15:00 and new Date(1970, 0, 1, 1, 15, 0, 0) for T01:15:00, but both Date objects return 1 for getHours().