Opened 11 years ago

Closed 8 years ago

#9101 closed enhancement (patchwelcome)

onDelete - deletedItem parameter is useless

Reported by: ben hockey Owned by: Jared Jurkiewicz
Priority: low Milestone: future
Component: Data Version: 1.3.0
Keywords: Cc:
Blocked By: Blocking:

Description

at the point when onDelete is called the deletedItem parameter no longer exists in the store. this may prevent access to any of the properties of the item and makes the deletedItem parameter useless.

perhaps an onBeforeDelete notification is needed before the item is actually removed from the store?

Change History (3)

comment:1 Changed 11 years ago by Jared Jurkiewicz

Possibly, yeah. FWIW, you can still do object reference checking and also call getIdentity() on deleted items, so it's not completely useless.

-- Jared

comment:2 Changed 10 years ago by Jared Jurkiewicz

Milestone: tbdfuture

comment:3 Changed 8 years ago by ben hockey

Priority: highlow
Resolution: patchwelcome
Status: newclosed

this obviously hasn't been too much of a problem. closing it.

Note: See TracTickets for help on using tickets.