Opened 10 years ago

Closed 10 years ago

#9097 closed defect (fixed)

[cla][patch] DropDownSelect doesn't not align vertically with other Dojo controls

Reported by: 7twenty Owned by: Nathan Toone
Priority: high Milestone: 1.4
Component: DojoX Form Version: 1.3.0
Keywords: Cc:
Blocked By: Blocking:

Description

Because dojox.form.DropDownSelect? renders a TABLE as the root node, it will not vertically align with other dojo controls. Example, if I have a ComboBox? and a DropDownSelect? on the same line, the DropDownSelect? will be rendered higher than the ComboBox?.

The best solution seems to be to change the DropDownSelect? to base its rendering on DIVs/SPANs instead of a TABLE (similar to Button, ComboBox?, Spinner, etc).

Attachments (1)

DropDownSelect.html (929 bytes) - added by 7twenty 10 years ago.
New DropDownSelect?.html

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by 7twenty

Attachment: DropDownSelect.html added

New DropDownSelect?.html

comment:1 Changed 10 years ago by 7twenty

I've implemented a quick prototype of a solution using the ComboBox? styles. Steps:

  1. Use the attached DropDownSelect?.html for dojox\form\resources\DropDownSelect?.html
  2. Change the DropDownSelect?'s baseClass to "dijitComboBox"

Test: dojox\form\tests\test_DropDownSelect.html

This gives a mostly functional DropDownSelect? based on divs instead of a table. It is visually similar to the ComboBox? with two desired exceptions:

  1. The entire widget is clickable (to open the dropdown)
  2. The widget resizes to match the length of the selected item

comment:2 Changed 10 years ago by bill

Component: DojoX WidgetsDojoX Form

comment:3 Changed 10 years ago by Nathan Toone

Milestone: tbd1.4
Owner: changed from dante to Nathan Toone

comment:4 Changed 10 years ago by Nathan Toone

Summary: DropDownSelect doesn't not align vertically with other Dojo controls[cla][patch] DropDownSelect doesn't not align vertically with other Dojo controls

comment:5 Changed 10 years ago by Nathan Toone

Note: the mis-alignment happens in IE when running in quirks mode.

comment:6 Changed 10 years ago by Nathan Toone

Resolution: fixed
Status: newclosed

(In [17304]) Fixes #9097 - different fix for this issue...a bit less disruptive and works in all mode in IE

Note: See TracTickets for help on using tickets.