Editor lineHeight not set correctly in IE

[rmaccracken]

In RichText.js, you will find the following code:

var lineHeight = _cs.lineHeight;
if(lineHeight.indexOf("px") >= 0){
    lineHeight = parseFloat(lineHeight)/parseFloat(_cs.fontSize);
}else if(lineHeight.indexOf("em")>=0){
    lineHeight = parseFloat(lineHeight);
}else {
    lineHeight = "1.0";
}

The last line (setting lineHeight to "1.0") seems to cause a problem with IE7 and IE8 (and maybe others) as it does not show up as a CSS rule (using new IE8 developer tools). This then causes a problem with the bottom of text being chopped off for letters like 'j' and 'g'.

To fix the problem all I did was add a condition to the last else clause:

} else if (!lineHeight) {

I don't know if that is the absolutely correct fix, but it worked for me. In IE8, the lineHeight variable is initially equal to "normal", so leaving it alone seems to solve the problem.

You can see this problem using the attached file or at the Dojo Campus docs: ​http://docs.dojocampus.org/dijit/Editor.

[rmaccracken]

Test case

[Jared Jurkiewicz]

I think the default should be 'normal', not 1.0.

[Jared Jurkiewicz]

(In [20447]) Fixing line-height def to default to normal instead of 1.0. Fixes an IE issue with truncation of letter 'tails'. \!strict fixes #9092