Opened 10 years ago

Closed 7 years ago

#9087 closed enhancement (fixed)

Add themed icons for when moving dojox.Grid columns

Reported by: Shane O'Sullivan Owned by: nonken
Priority: low Milestone: 1.7
Component: themes Version: 1.3.0
Keywords: needsreview Cc: nonken
Blocked By: Blocking:

Description

When moving columns in the Grid, arrow icons are placed above and below the point at which the column will be inserted. However, the icons used are not very attractive, and better icons, more suited to each theme, should be added

Change History (3)

comment:1 Changed 10 years ago by Nathan Toone

Component: DojoX Gridthemes
Milestone: tbdfuture
Owner: changed from Bryan Forbes to nonken
Type: defectenhancement

comment:2 Changed 7 years ago by ben hockey

Keywords: needsreview added
Priority: highlow

comment:3 Changed 7 years ago by bill

Milestone: future1.7
Resolution: fixed
Status: newclosed
Summary: Add themed icons for when moving dojo.Grid columnsAdd themed icons for when moving dojox.Grid columns

The icons in http://download.dojotoolkit.org/release-1.7.1/dojo-release-1.7.1/dojox/grid/tests/test_grid_column_reorder.html look good to me.

And I can see from tundraGrid.css that it's using a theme specific arrow:

.tundra .dojoxGridArrowButtonNode {
        display: block !important;
        padding-left: 0px;
        float: right;
        background:url("../../../dijit/themes/tundra/images/spriteArrows.png") no-repeat left center;
        width: 7px;
        height: 1em;
        margin: 2px 4px 0px 5px;
}
.dj_ie6 .tundra .dojoxGridArrowButtonNode {
        background-image:url("../../../dijit/themes/tundra/images/spriteArrows.gif");
        margin-left: 0px;
}

and for claro:

.claro .dojoxGridArrowButtonNode {
        background:transparent url("../../../dijit/themes/claro/images/spriteArrows.png") no-repeat scroll left center;
        display:block;
        float:right;
        height:1em;
        margin:2px 4px 0 5px;
        padding-left:0;
        width:7px;
}
.claro .dojoxGridSortUp .dojoxGridArrowButtonNode {
        background-position:-21px 50%;
}

Since @nonken isn't active with dojo I'll close this.

Note: See TracTickets for help on using tickets.