Lightbox and Dialog have odd residual layout artifact

[dante]

If you open test_Lightbox.html, open the "larger than viewport" (or actually any of them) lightbox, then close it -- if you resize the browser to be smaller than the right or bottom coords of the dialog before closing, you see a window-level scrollbar. This was reportd in #9073 with other items, but should have it's own ticket.

[dante]

k figured it out, this is Dialog's issue. from irc:

[10:42a] phiggins:
I found the reason, and know how to fix but wanted to run by you
[10:42a] phiggins:
(it is in dijit.Dialog)
[10:42a] phiggins:
in Dialog's postCreate, it sets the node offscreen by top:-9999px only
[10:43a] phiggins:
so it is still 'centered' in the screen
[10:43a] phiggins:
then if you resize too small, it's still top:-9999 but it's left/right are unchanged, causing scrollbars
[10:43a] phiggins:
something like var prop = this.isLtr ? "left" : "right"; style[prop] = "-999px" would fix
[10:44a] phiggins:
visibility:hidden preserves layout, hence the scrollbars

[dante]

my fix. bill said something about contentpane and changing how dialog is hidden again. this seems easier.

[bill]

Right, I think now that ContentPane calls resize() on it's "children" when it's shown, that we could just hide it via display:none.

That was the trend in 0.3 (TabContainer etc. uses display:none) but I didn't bother changing it for Dialog or the dijit.popup code. IIRC there wasn't a good reason *not* to, I just left it because it was working (except for this new problem). Although, it would expose issues for widgets inside a Dialog that misbehave and try to do layout on initialization rather than waiting for a resize() call.

[bill]

Fixed in [17256].