Opened 12 years ago
Closed 12 years ago
#9080 closed defect (fixed)
Lightbox and Dialog have odd residual layout artifact
Reported by: | dante | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | Dijit | Version: | 1.3.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
If you open test_Lightbox.html, open the "larger than viewport" (or actually any of them) lightbox, then close it -- if you resize the browser to be smaller than the right or bottom coords of the dialog before closing, you see a window-level scrollbar. This was reportd in #9073 with other items, but should have it's own ticket.
Attachments (1)
Change History (6)
comment:1 Changed 12 years ago by
Component: | Dojox → Dijit |
---|
Changed 12 years ago by
Attachment: | Dialog.patch added |
---|
my fix. bill said something about contentpane and changing how dialog is hidden again. this seems easier.
comment:2 Changed 12 years ago by
Right, I think now that ContentPane calls resize() on it's "children" when it's shown, that we could just hide it via display:none.
That was the trend in 0.3 (TabContainer etc. uses display:none) but I didn't bother changing it for Dialog or the dijit.popup code. IIRC there wasn't a good reason *not* to, I just left it because it was working (except for this new problem). Although, it would expose issues for widgets inside a Dialog that misbehave and try to do layout on initialization rather than waiting for a resize() call.
comment:3 Changed 12 years ago by
Summary: | Lighbox (perhaps Dialog) has odd residual layout artifact → Lightbox (perhaps Dialog) has odd residual layout artifact |
---|
comment:4 Changed 12 years ago by
Owner: | changed from dante to bill |
---|---|
Status: | new → assigned |
comment:5 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Summary: | Lightbox (perhaps Dialog) has odd residual layout artifact → Lightbox and Dialog have odd residual layout artifact |
Fixed in [17256].
k figured it out, this is Dialog's issue. from irc: