#9078 closed defect (fixed)
Tree: hardcoded 19px padding breaking my site's layout
| Reported by: | Scott Moxham | Owned by: | bill |
|---|---|---|---|
| Priority: | high | Milestone: | 1.4 |
| Component: | Dijit | Version: | 1.3.0 |
| Keywords: | padding tree | Cc: | |
| Blocked By: | Blocking: |
Description
v1.3.0 has added some inline paddingLeft of 19px into the dijit.tree nodes for indentation. This was not in 1.2.3 and it breaks the layout of my site.
This indent really needs to be in CSS instead of inline so that it can be easily overridden.
Change History (6)
comment:1 Changed 13 years ago by
| Milestone: | tbd → 1.4 |
|---|---|
| Owner: | set to bill |
| Summary: | Newly introduced inline padding in dijit.tree breaking my site's layout → Tree: hardcoded 19px padding breaking my site's layout |
comment:2 Changed 13 years ago by
Can someone please describe how to fix this manually. For some reason, I have had difficulty finding where the 19px indentation is hard-coded. Thanks.
comment:3 Changed 13 years ago by
I'm going to work on this soon but to change it manually just search for the string "19" in Tree.js.
comment:4 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [17543]) Make indent for Tree's nodes adjustable via CSS.
Since dojo.marginBox() doesn't work reliably until the Tree's DOM node is inserted into the document and is visible, the CSS width is read when Tree.resize() is called. If Tree.resize() isn't called then it defaults to 19px, as before (for backwards compatibility).
Fixes #9078 !strict.
Yup, I agree, I added a comment for this in [16088] but forgot to file a ticket for it (or fix it). Thanks for the reminder.