Opened 11 years ago

Closed 10 years ago

#9066 closed defect (fixed)

dojox.grid.DataGrid should check to see if it has been destroyed mid-download

Reported by: Phil DeJarnett Owned by: Bryan Forbes
Priority: high Milestone: 1.4
Component: DojoX Grid Version: 1.3.0
Keywords: dojox.grid.DataGrid Cc:
Blocked By: Blocking:

Description

I use the Grid with QueryReadStore? in a fairly advanced interface. This interface can swap out grids dynamically.

Currently, if someone is click-happy, and changes sections while a grid is still waiting on data, the waiting grid will end up causing errors once the download completes. This is because QueryReadStore? will complete even if the grid has been destroyed, and the DataGrid? JS object will still exist for the onBegin and onComplete callbacks.

A simple resolution that has worked for me was to add

if(!this.domNode) {
    return;
} 

at the top of _onFetchBegin(), _onFetchComplete(), and _resize().

This is a very quick check, and prevents the grid from trying to process the results of a query if the grid has already been destroyed.

Change History (1)

comment:1 Changed 10 years ago by Nathan Toone

Milestone: tbd1.4
Resolution: fixed
Status: newclosed

This has been fixed in trunk. Please reopen with a test case if you are still seeing an issue.

Note: See TracTickets for help on using tickets.