Opened 11 years ago

Closed 10 years ago

#9065 closed defect (fixed)

improve gfx and charting performance for text layout

Reported by: alex Owned by: Eugene Lazutkin
Priority: high Milestone: 1.4
Component: DojoX GFX Version: 1.3.0
Keywords: performance, gfx, charting, marginBox, layout Cc: alex, dante
Blocked By: Blocking:

Description

dojox.gfx._base includes a method called _getTextBox which is a significant performance problem. This code is replicated in the dojox.charting.axis2d.common API as the HTML variant of the createText method. Both of these methods make expensive calls to dojo.marginBox(). Charting axes should likely batch calls to find a maximum size wheras gfx should (at a minimum) use getBoundingClientRect where available. Getting actual border/margin boxes is likely less important in these cases than ensuring timely layout.

Change History (2)

comment:1 Changed 10 years ago by liucougar

(In [17597]) refs #9065: TextRectangle? object returned by getBoundingClientRect does not have width/height, it only has top/left/right/bottom this breaks underline shape in dojox.sketch

comment:2 Changed 10 years ago by Eugene Lazutkin

Resolution: fixed
Status: newclosed

This functionality was implemented by #9011 and refined in by #9357.

Note: See TracTickets for help on using tickets.