Opened 10 years ago

Closed 10 years ago

#9054 closed enhancement (fixed)

Surface.getDimensions() returns incorrect type in SVG mode

Reported by: Fredrik Owned by: Eugene Lazutkin
Priority: high Milestone: 1.4
Component: DojoX GFX Version: 1.3.0
Keywords: Cc:
Blocked By: Blocking:

Description

file: svg.js

Surface.getDimensions() returns plain getAttribute data, resulting in width and height are returned as strings instead of integers.

solution: change to use same code as in vml.js (using normalizedLength)

Change History (3)

comment:1 Changed 10 years ago by Eugene Lazutkin

Milestone: tbd → 1.4
Status: new → assigned

comment:2 Changed 10 years ago by Eugene Lazutkin

Type: defect → enhancement

Actually it was supposed to return strings in order to be compatible with setDimensions(). On the other hand pixels are most useful for programmers (no need to parse), and it will be consistent with other renderers, which all return numbers.

comment:3 Changed 10 years ago by Eugene Lazutkin

Resolution: → fixed
Status: assigned → closed

(In [20326]) dojox.gfx: making SVG render returning number of pixels rather than strings for getDimenstions(), thx Fredrik!, !strict, fixes #9054.

Note: See TracTickets for help on using tickets.