Opened 11 years ago

Closed 8 years ago

#9045 closed defect (invalid)

Weird condition in query.js file (dojo/base)

Reported by: julienlegall Owned by: julienlegall
Priority: low Milestone: future
Component: Query Version: 1.3.0
Keywords: query safari webkit Cc:
Blocked By: Blocking:

Description

I have a problem in a complex example using dojo.query. The unit tests passed. I make simpler samples and they work. I search in query.js file and I found a line which seems weird for me.

var is525 = (
		d.isWebKit && 
		(nua.indexOf(wk) > 0) && 
		(parseFloat(nua.split(wk)[1]) > 528)
	);

line 1171

528 seems to be the version of webkit and the name of the variable is is525. Should 525 not be replaced by 525 ?

My sample works in Safari 3.2.2 but not in 3.1.2. They both used webkit version 525. In my sample when I use 525 instead of 528, it works.

Thank for your help.

Julien

PS : I talk about this with people on irc, Peller tells me to post a bug.

Change History (10)

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from anonymous to alex

comment:2 Changed 10 years ago by bill

Component: CoreQuery

comment:3 Changed 10 years ago by dante

Milestone: tbdfuture

comment:4 Changed 9 years ago by Chris Mitchell

Owner: changed from alex to dylan

please review/triage

comment:5 Changed 8 years ago by ben hockey

Owner: changed from dylan to julienlegall
Priority: highlow
Status: newpending

Please provide a test case showing the problem.

comment:6 Changed 8 years ago by bill

Note that this is525 code prevents acme (the old dojo.query() engine) from using document.querySelectorAll() when the webkit version < 528, since it had a buggy implementation. See #5832. But we are no longer supporting safari 3.1, or even safari 4, so the is525 code isn't needed at all.

Of course that won't solve the problem of this ticket, which was something with the non querySelectorAll() code path. Presumably that problem is still happening on browsers like IE8, that don't support querySelectorAll().

Last edited 8 years ago by bill (previous) (diff)

comment:7 Changed 8 years ago by bill

Resolution: fixed
Status: pendingclosed

In [27941]:

Remove codepath for desupported safari 3.1. Refs #5832, #9045, #11844 !strict. Presumably doesn't fix #9045, which is awaiting a test case.

comment:8 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: closedreopened

looks like this was accidentally closed

comment:9 Changed 8 years ago by Adam Peller

Status: reopenedpending

comment:10 Changed 8 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.