Opened 12 years ago
Closed 9 years ago
#9045 closed defect (invalid)
Weird condition in query.js file (dojo/base)
Reported by: | julienlegall | Owned by: | julienlegall |
---|---|---|---|
Priority: | low | Milestone: | future |
Component: | Query | Version: | 1.3.0 |
Keywords: | query safari webkit | Cc: | |
Blocked By: | Blocking: |
Description
I have a problem in a complex example using dojo.query. The unit tests passed. I make simpler samples and they work. I search in query.js file and I found a line which seems weird for me.
var is525 = ( d.isWebKit && (nua.indexOf(wk) > 0) && (parseFloat(nua.split(wk)[1]) > 528) );
line 1171
528 seems to be the version of webkit and the name of the variable is is525. Should 525 not be replaced by 525 ?
My sample works in Safari 3.2.2 but not in 3.1.2. They both used webkit version 525. In my sample when I use 525 instead of 528, it works.
Thank for your help.
Julien
PS : I talk about this with people on irc, Peller tells me to post a bug.
Change History (10)
comment:1 Changed 12 years ago by
Owner: | changed from anonymous to alex |
---|
comment:2 Changed 11 years ago by
Component: | Core → Query |
---|
comment:3 Changed 11 years ago by
Milestone: | tbd → future |
---|
comment:4 Changed 10 years ago by
Owner: | changed from alex to dylan |
---|
comment:5 Changed 9 years ago by
Owner: | changed from dylan to julienlegall |
---|---|
Priority: | high → low |
Status: | new → pending |
Please provide a test case showing the problem.
comment:6 Changed 9 years ago by
Note that this is525 code prevents acme (the old dojo.query() engine) from using document.querySelectorAll() when the webkit version < 528, since it had a buggy implementation. See #5832. But we are no longer supporting safari 3.1, or even safari 4, so the is525 code isn't needed at all.
Of course that won't solve the problem of this ticket, which was something with the non querySelectorAll() code path. Presumably that problem is still happening on browsers like IE8, that don't support querySelectorAll().
comment:8 Changed 9 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
looks like this was accidentally closed
comment:9 Changed 9 years ago by
Status: | reopened → pending |
---|
comment:10 Changed 9 years ago by
Resolution: | → invalid |
---|---|
Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
please review/triage