Opened 10 years ago

Closed 10 years ago

#9026 closed defect (fixed)

[patch]gfx splitFontString does not correctly hand font-variant

Reported by: masnare Owned by: Eugene Lazutkin
Priority: high Milestone: 1.4
Component: DojoX GFX Version: 1.3.0rc2
Keywords: 1.3 Cc:
Blocked By: Blocking:

Description

The variant in the font input string is recorded as 'varian' instead of 'variant'. This will lead to issues for clients (like the charting features...)

Attachments (1)

dojox-gfx-_base.js.diff​ (781 bytes) - added by dinkypumpkin 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by Adam Peller

Component: General → DojoX GFX
Keywords: 1.3 added; gfx splitFontString font variant fontVariant removed
Owner: changed from anonymous to Eugene Lazutkin

comment:2 Changed 10 years ago by Adam Peller

Apparently this ticket is referring to the code in dojox.gfx.splitFontString

comment:3 Changed 10 years ago by Eugene Lazutkin

Milestone: tbd → future
Status: new → assigned

Please add a minimalistic test case to see the problem (before the fix) and make sure that the result is right (after the fix).

comment:4 Changed 10 years ago by dinkypumpkin

Suggested patch is attached. Also fixes problem whereby font family was never set from CSS font string.

Changed 10 years ago by dinkypumpkin

Attachment: dojox-gfx-_base.js.diff​ added

comment:5 Changed 10 years ago by Adam Peller

Milestone: future → 1.4
Summary: gfx splitFontString does not correctly hand font-variant → [patch]gfx splitFontString does not correctly hand font-variant

comment:6 Changed 10 years ago by Eugene Lazutkin

Resolution: → fixed
Status: assigned → closed

(In [20325]) dojox.gfx: fixing a typo and making the font splitting algorithm right, thx masnare and dinkypumpkin!, !strict, fixes #9026.

Note: See TracTickets for help on using tickets.