#9018 closed defect (fixed)
[regression] DateTextBox: fires onChange twice
Reported by: | Jarrod Carlson | Owned by: | Adam Peller |
---|---|---|---|
Priority: | high | Milestone: | 1.3.1 |
Component: | Dijit - Form | Version: | 1.3.0rc2 |
Keywords: | dijit form datetextbox | Cc: | |
Blocked By: | Blocking: |
Description
I found a previous ticket covering this issue: #5312
It looks like in the latest Dojo 1.3, this problem is still present. The Dijit tests themselves illustrate this problem: http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_DateTextBox.html
Choose a date in the first box, and upon clicking the date, the text box to the right is set with the selected date, at 1:00 AM. As soon as the widget is blurred, the text box is updated again, this time with the date normalized to midnight.
I can't imagine this is "expected behavior", but if it is, could someone please explain why the first onChange event fires with the date set to 1:00 AM?
This occurred in both Safari 3 (Mac) and Firefox 3 (Mac).
Attachments (1)
Change History (9)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
Owner: | set to Douglas Hays |
---|
comment:3 Changed 12 years ago by
Owner: | changed from Douglas Hays to Adam Peller |
---|
Regression caused by #8521. onValueSelected is being called with a time component of 1am and time should be 0.
comment:4 Changed 12 years ago by
Running test_TimeTextBox.html, I'm not seeing the onChange fire twice.
Changed 12 years ago by
Attachment: | 9018.patch added |
---|
Proposed patch to pass back dates set to midnight, as before 1.3
comment:5 Changed 12 years ago by
Summary: | Regression(?): DateTextBox and TimeTextBox fire onChange twice → [regression] DateTextBox: fires onChange twice |
---|
comment:7 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
fixed in 1.3 branch in [17257]
comment:8 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
Hmm, yeah, comparing against http://download.dojotoolkit.org/release-1.2.3/dojo-release-1.2.3/dijit/tests/form/test_DateTextBox.html, it is a regression in the sense that onChange is getting called twice.
I'm in Japan's timezone so in dojo 1.2.3 I get +9 (9AM), which is also weird, but the double onChange event in 1.3 is what concerns me more.