[regression] DateTextBox: fires onChange twice

[Jarrod Carlson]

I found a previous ticket covering this issue: #5312

It looks like in the latest Dojo 1.3, this problem is still present. The Dijit tests themselves illustrate this problem: ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_DateTextBox.html

Choose a date in the first box, and upon clicking the date, the text box to the right is set with the selected date, at 1:00 AM. As soon as the widget is blurred, the text box is updated again, this time with the date normalized to midnight.

I can't imagine this is "expected behavior", but if it is, could someone please explain why the first onChange event fires with the date set to 1:00 AM?

This occurred in both Safari 3 (Mac) and Firefox 3 (Mac).

[bill]

Hmm, yeah, comparing against ​http://download.dojotoolkit.org/release-1.2.3/dojo-release-1.2.3/dijit/tests/form/test_DateTextBox.html, it is a regression in the sense that onChange is getting called twice.

I'm in Japan's timezone so in dojo 1.2.3 I get +9 (9AM), which is also weird, but the double onChange event in 1.3 is what concerns me more.

[Douglas Hays]

Regression caused by #8521. onValueSelected is being called with a time component of 1am and time should be 0.

[Douglas Hays]

Running test_TimeTextBox.html, I'm not seeing the onChange fire twice.

[Adam Peller]

Proposed patch to pass back dates set to midnight, as before 1.3

[Adam Peller]

checked into trunk in [17188]

[Adam Peller]

fixed in 1.3 branch in [17257]