Opened 11 years ago

Closed 11 years ago

#8992 closed defect (fixed)

[patch][cla] dijit.Menu: submenus appearing out of the viewport

Reported by: Nathan Toone Owned by: Nathan Toone
Priority: high Milestone: 1.4
Component: Dijit Version: 1.3.0rc2
Keywords: Cc:
Blocked By: Blocking:

Description

This can be seen in the dijit/tests/test_Menu.html test case.

Steps to duplicate: 1 - open a context menu so that the bottom of the menu is barely above the bottom of the viewport. 2 - open the "Different Popup" submenu

Expected results: The entire color picker popup should be displayed in the current viewport

Actual results: The bottom of the color picker popup is chopped off below the bottom of the viewport. Note that this even happens if you are scrolled to the bottom of the page - the page gets "extended" to make way for the popup - but the popup still shows off-screen.

See the attached screenshot for the actual results (There are 7 total rows of colors in the color picker popup). If you open a context menu so that the bottom of the menu is *barely* above the bottom of the viewport (you may need to open the context menu quite a few different locations to get the exact positioning).

Attachments (3)

SubmenuOffScreen.png (27.6 KB) - added by Nathan Toone 11 years ago.
Screenshot showing the off-screen submenu
testPatchBigList.patch (1.3 KB) - added by Nathan Toone 11 years ago.
This patch updates the test case context menu to better illustrate this issue
menuSubmenuPlacement.diff (1.9 KB) - added by Nathan Toone 11 years ago.
Patch which fixes this issue

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Nathan Toone

Attachment: SubmenuOffScreen.png added

Screenshot showing the off-screen submenu

Changed 11 years ago by Nathan Toone

Attachment: testPatchBigList.patch added

This patch updates the test case context menu to better illustrate this issue

Changed 11 years ago by Nathan Toone

Attachment: menuSubmenuPlacement.diff added

Patch which fixes this issue

comment:1 Changed 11 years ago by Nathan Toone

Summary: dijit.Menu: submenus appearing out of the viewport[patch][cla] dijit.Menu: submenus appearing out of the viewport

comment:2 Changed 11 years ago by bill

Looks good to me. It's quite similar to #8948.

comment:3 Changed 11 years ago by Nathan Toone

Milestone: 1.41.3.1

Fixed on the trunk in [17152] - updating to 1.3.1 for consideration for inclusion on the branch.

comment:4 Changed 11 years ago by Nathan Toone

Milestone: 1.3.11.4
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.