Opened 10 years ago

Closed 9 years ago

#8983 closed defect (fixed)

MenuBar borderContainer classes risky

Reported by: dante Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit - LnF Version: 1.3.0b3
Keywords: Cc: bill, nonken
Blocked By: Blocking:

Description

For some reason MenuBar isn't getting the class ".dijitBorderContainer-dijitMenuBar" set when it is a child of a borderContainer. Adding a MenuBar to themeTester exposed this. This is to track the fix for the class (baseClass related?)

Going to fix for the non-embedded case, and add to themeTester in 1.3 as part of #8885, but need to address the larger issue.

Change History (4)

comment:1 Changed 10 years ago by dante

started in [17124]

comment:2 Changed 10 years ago by dante

Milestone: 1.4 → 1.5

comment:3 Changed 9 years ago by bill

Owner: changed from dante to bill
Status: new → assigned

Right, Menu is missing baseClass.

Incidentally, I had actually planned to add baseClass and convert Menu to use _CssStateMixin, but Menu has a weird usage of the word "active": dijitMenuActive refers not to a mouse-down event on the menu but to the menu having been focused, after which merely hovering a MenuItem will open it.

Anyway I'll add baseClass.

comment:4 Changed 9 years ago by bill

Resolution: → fixed
Status: assigned → closed

(In [21348]) Add baseClass for Menu and MenuBar so that a MenuBar as a child of a BorderContainer gets the right class name. Fixes #8983 !strict.

Note: See TracTickets for help on using tickets.