Lightbox errors on ie7

[Josh Trutwin]

In 1.3rc1 testing seems that dojox.image.Lightbox does not work well with ie7. I found that it seems to be throwing there error due to receive a NaN on a height property in dojo.style.

Firefox 2,3 do not have any issues.

I also checked the nightly test_Lightbox.html page on ie7 and also errors out.

In both cases the background fades to black and about 50x50 white box shown in middle of screen for start of Lightbox expand animation, but stops there.

[Josh Trutwin]

Problem exists in ie6 as well.

[Josh Trutwin]

This change is what caused the problem:

​http://bugs.dojotoolkit.org/changeset/16970

dojox.fx.sizeTo (_base.js) gets auto in dojo.getComputedStyle(node), where node is lightbox containerNode, converts to NaN, caused problem.

Nightly tests from 3/9 work, 3/10 do not.

[Josh Trutwin]

Please add doughays to CC

[Josh Trutwin]

I was able to get Lightbox to work by modified dojox.fx._base.js sizeTo to check cs.width,cs.height for 'auto' and set to 0, otherwise parseInt. Not sure what problems this could cause tho.

[dante]

so modifying sizeTo to handle this makes some sense, but I don't like that a change in Dijit [once again] broke something internally like this, especially considering the bug "fixed" that broke this was a self-opened-self-closed-on-the-same-day ticket, and appears to be an edge case anyway: #8837

[Josh Trutwin]

patch to dojox.fx._base.js to handle auto on width/height

[Josh Trutwin]

Added a patch against trunk to trap the height/width = 'auto'.

While doing this I noticed that the previous loading effect in dojox.image.Lightbox has degraded to a 20x20 pixel box on both FF and IE. It used to be about 100x100 px with a nice animated icon indicating load "progress".

Compare:

​http://archive.dojotoolkit.org/dojo-2009-03-09/dojotoolkit/dojox/image/tests/test_Lightbox.html

to:

​http://archive.dojotoolkit.org/dojo-2009-03-10/dojotoolkit/dojox/image/tests/test_Lightbox.html

Maybe backout the change to 8837 or alternate solution?

Josh

[dante]

buggar. post-commit still broken. fixed in [17121]

[bill]

(In [19278]) Remove "janktastic solution to #8967", which is no longer needed after [19277], since Lightbox doesn't even call Dialog._size(). Refs #8967, #9588 !strict.