Form: when multiple fields initially invalid/required+blank, correcting one field marks form as valid

[Jarrod Carlson]

_FormMixin.isValid() uses dojo.every() to build an array of invalid child widgets. This behavior is broken, though, because dojo.every() stops on the first non-truthy iteration.

Thus, if a form contains two required text fields and both are blank, the isValid() method will only catch the first invalid widget and then stop.

Subsequently, when _FormMixin._widgetChange() is invoked by a child widget becoming valid, the entire form is not re-validated, only the array on _invalidWidgets, which is not complete. The onValidStateChange handler is thus incorrectly fired, and the form is considered valid when it is not.

Attached is a test page to illustrate this issue.

To rectify the problem, isValid() should use another method of locating invalid descendants.

I would call this a pretty critical bug, but it should be fairly easy to fix. If I have time today, I might be able to submit a patch...

[Jarrod Carlson]

test file demonstrating defect in _FormMixin.isValid()

[Jarrod Carlson]

Patch for _FormMixin.js

[Jarrod Carlson]

Actually, the change was incredibly simple, and the attached patch should take care of it...

[bill]

I see your point. This is fallout from #7788.

Thanks for the patch. BTW in this case a marginally better way to do it is to call dojo.filter() to generate the array. Anyway, I'll try to checkin for 1.3.

[bill]

Fixed in [17106], thanks for catching this!

[bill]

Plus typo fix in [17120].

[bill]

(In [17613]) Automated testcase for initially invalid form. Refs #8966.