Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#8964 closed task (fixed)

Spinner: focus ARIA tests on known test cases instead of looping.

Reported by: Joseph Scheuhammer Owned by:
Priority: high Milestone: 1.3
Component: Dijit - Form Version: 1.3.0b3
Keywords: ARIA robot test Cc: bill, Becky Gibson
Blocked By: Blocking:

Description

The ARIA tests in ".../dijit/tests/form/robot/Spinner_a11y.html" loop through a number of Spinner instances, and test for ARIA role, valuemin, and valuemax (among others). Instead of looping, the tests should run against representative cases.

Attachments (1)

8964.patch (6.5 KB) - added by Joseph Scheuhammer 11 years ago.
Tests for role, aria-valuemin, and aria-valuemax for representative cases (no looping).

Download all attachments as: .zip

Change History (4)

comment:1 Changed 11 years ago by Joseph Scheuhammer

The file "8964.patch", tests against representative examples as follows.

First, the role is assigned in the spinner template -- only one spinner it tested, on the assumption that all spinners are created using the template.

Secondly, spinners can have both minimum and maximum values, only a minimum, only a maximum, or neither. The aria-valuemin and aria-valuemax attributes are tested for these four cases.

Note: the patch also includes the same fix for #8796 as provided in "8796.patch".

Changed 11 years ago by Joseph Scheuhammer

Attachment: 8964.patch added

Tests for role, aria-valuemin, and aria-valuemax for representative cases (no looping).

comment:2 Changed 11 years ago by bill

Milestone: tbd1.3
Resolution: fixed
Status: newclosed
Type: enhancementtask

OK thanks, I checked this in as [17117].

comment:3 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.