Opened 12 years ago

Closed 5 years ago

#8953 closed defect (patchwelcome)

[patch] [cla] RTL broken in quirks mode (IE)

Reported by: bill Owned by: bill
Priority: low Milestone: 1.11
Component: HTML Version: 1.3.0b3
Keywords: needsreview Cc: Douglas Hays
Blocked By: Blocking:

Description

The html_rtl.html test case, if converted to quirksmode, is failing on all IE versions.

(Also, we are missing a test file for RTL quirksmode as part of standard runTests.html)

Attachments (2)

8953.patch​ (997 bytes) - added by Douglas Hays 11 years ago.
if and when html_quirks_rtl.html is created, patch shows what needs to change to fix this
html_rtl_quirks.html​ (5.2 KB) - added by bill 8 years ago.
test case, put in dojo/tests/_base

Download all attachments as: .zip

Change History (10)

comment:1 Changed 12 years ago by James Burke

Component: Internationalization → Core
Milestone: tbd → future
Owner: changed from Adam Peller to anonymous

Talking with Bill, this is a tracking bug to add the tests and do the fix at some point, but to date we have not gotten in-the-field reports of the issue (RTL in quirks mode), so it is not a blocker for 1.3.

Changed 11 years ago by Douglas Hays

Attachment: 8953.patch​ added

if and when html_quirks_rtl.html is created, patch shows what needs to change to fix this

comment:2 Changed 9 years ago by Chris Mitchell

Owner: anonymous deleted

comment:3 Changed 9 years ago by ben hockey

Keywords: needsreview added
Priority: high → low

comment:4 Changed 9 years ago by bill

Component: Core → HTML
Owner: set to Eugene Lazutkin
Status: new → assigned
Summary: RTL broken in quirks mode (IE) → [patch] [cla] RTL broken in quirks mode (IE)

comment:5 Changed 8 years ago by Eugene Lazutkin

Do we have a test for the patch?

Changed 8 years ago by bill

Attachment: html_rtl_quirks.html​ added

test case, put in dojo/tests/_base

comment:6 Changed 8 years ago by bill

Cc: Douglas Hays added

I attached the test case, generated from html_rtl.html... Doug, from your patch, are you saying the failure is just a problem with the test case (rather than a problem with the code)?

comment:7 Changed 5 years ago by dylan

Milestone: future → 1.11
Owner: changed from Eugene Lazutkin to bill
Status: assigned → pending

Is there interest in revisiting this and/or landing it? Otherwise please close as patchwelcome (for an updated patch against master). Thanks!

comment:8 Changed 5 years ago by bill

Resolution: → patchwelcome
Status: pending → closed
Note: See TracTickets for help on using tickets.