Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#895 closed defect (fixed)

dojo.html.selectElement doesn't work in Safari

Reported by: sgendler@… Owned by: dylan
Priority: high Milestone:
Component: HTML Version: 0.2
Keywords: Cc: sgendler@…
Blocked By: Blocking:

Description

selection.selectAllChildren() doesn't function in Safari. You must call setBaseAndExtent() instead, which is essentially undocumented anywhere on the web, including any webkit docs themselves. So here's a patch which has worked everywhere that I've tested it, but I don't have any guarantees that it is actually correct. Note that if someone copied the patch I submitted to the mailing list, it isn't quite correct. This one is, as far as I can tell. Again, this is a patch against dojo 0.3 distribution (kitchen sink)

Attachments (1)

patch.txt (764 bytes) - added by sgendler@… 13 years ago.

Download all attachments as: .zip

Change History (10)

Changed 13 years ago by sgendler@…

Attachment: patch.txt added

comment:1 Changed 13 years ago by dylan

Component: GeneralHTML
Milestone: 0.4
Owner: changed from anonymous to dylan

CLA on file?

comment:2 Changed 13 years ago by dylan

Status: newassigned

comment:3 Changed 13 years ago by dylan

I still really need a CLA before I can merge this, even if it is just a 3-line patch.

comment:4 Changed 13 years ago by jkuhnert

Are you going to do the CLA sam ? I know you keep complaining about things being broken . .. :)

comment:5 Changed 13 years ago by jkuhnert

Cc: sgendler@… added

Hey Sam...Maybe you didn't get all these previous comment questions before.

comment:6 Changed 13 years ago by guest

Confirmed that CCLA was signed and received by Alex Russell on June 03 of this year I just forwarded his email confirming receipt back to him.

comment:7 Changed 13 years ago by dylan

For some reason, Sam's not on the list, but I'll take your word for it.

comment:8 Changed 13 years ago by dylan

Resolution: fixed
Status: assignedclosed

(In [5690]) fixes #895, dojo.html.selectElement doesn't work in Safari

comment:9 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.