[patch][cla]Accordion enhancement to allow setting of panel size (bug portion of this ticket already fixed)

[[email protected]…]

After fixing the problem with dojo.style.getUnitValue(), the AccordionPane? widget was still having problems in Safari when it was created in script within a div that had display:none. It turned out that the problem was in the setSizes() method which was doing math to calculate how large the containerNode should be. Unfortunately, it was receiving NaN as a value and then doing math with it, which resulted in a value equal to NaN as well. Needless to say, ll the containerNodes wound up with a height of 0px.

Here is a simple patch which just checks that the value is a value before allowing it to be used in height calculations.

I have also attached a copy of a subclass of AccordionContainer? that I am now having to use which adds a method which can be called AFTER the container is displayed so that the sizes can be recomputed. It also lets you specify how big each pane will be and sets the size of the parent node accordingly. I'd love to see it integrated into dojo, but will continue to use my subclass if not.

[anonymous]

Bill, you might want to take a look at the patch I submitted in bug 893, as it is related to this one. That's what I am referring to in the first sentence of my description.

[dylan]

Do we have a CLA on file? Is this still an issue?

[jkuhnert]

Hey Sam...Adding you in...I think they want your CLA :)

[guest]

My CLA was filed the same day that these bugs were added. I even discussed it with Alex. I scanned and emailed it to him and I know he received it.

[guest]

Confirmed that CCLA was signed and received by Alex Russell on June 03 of this year I just forwarded his email confirming receipt back to him.

[Adam Peller]

from [email protected] (CCLA on file) I believe the patch to AccordionPane?.js for problem #894 is unnecessary and does not fix the real problem. I tracked the NaN problem down to src/html/layout.js line 277: if(typeof args.width != undefined){ should be if(typeof args.width != "undefined"){ Note the quotes. Same problem with lines 281, 301, 306

[Douglas Hays]

I believe the patch to AccordionPane?.js for problem #894 is unnecessary and does not fix the real problem. I tracked the NaN problem down to src/html/layout.js line 277: if(typeof args.width != undefined){ should be if(typeof args.width != "undefined"){ Note the quotes. Same problem with lines 281, 301, 306

[Adam Peller]

(In [5535]) Fixes #894 (thanks [email protected]…)

[Adam Peller]

It seems that there were two unrelated issues in this ticket. The first issue relating to the NaN appears to have been fixed. sgendler, please verify and open a new ticket with a test case referencing this one if it is not. The second issue was an enhancement request on the Accordion widget, so I'm moving the milestone back to 0.5 and assigning back to Bill. The patch is not in a state which can be directly integrated into dojo.widget.*, so I'll leave it to Bill to decide if we should proceed.

[Adam Peller]

Koranteng, sorry this one got stale. Could you please evaluate?

[Adam Peller]

Sorry again that we let this get stale. I think the problems have largely been addressed prior to the 0.9, and hopefully even more so now with the Dijit rewrite.